Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

Commit c342fd6

Browse files
authored
FCE-2188: Use username from server metadata as display name (#523)
## Description We need to use username from server metadata as display name. ## Motivation and Context Web is not sending displayName in peer metadata. ## Documentation impact - [ ] Documentation update required - [ ] Documentation updated [in another PR](_) - [x] No documentation update required ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
1 parent 5f2ee75 commit c342fd6

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

internal/fishjam-chat/components/VideosGrid/parsePeersToTracks.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { PeerWithTracks } from '@fishjam-cloud/react-native-client/build/hooks/usePeers';
22
import { GridTrack } from './GridTrackItem';
3-
import { PeerMetadata } from '../../types/metadata';
3+
import { PeerMetadata, ServerMetadata } from '../../types/metadata';
44

55
const createGridTracksFromPeer = (
6-
peer: PeerWithTracks<PeerMetadata>,
6+
peer: PeerWithTracks<PeerMetadata, ServerMetadata>,
77
): GridTrack[] => {
88
const tracks: GridTrack[] = [];
99

@@ -12,7 +12,7 @@ const createGridTracksFromPeer = (
1212
...peer.cameraTrack,
1313
peerId: peer.id,
1414
isLocal: peer.isLocal,
15-
userName: peer.metadata.peer?.displayName,
15+
userName: peer.metadata.server?.username,
1616
isVadActive: peer.microphoneTrack?.vadStatus === 'speech',
1717
aspectRatio: peer.cameraTrack.aspectRatio,
1818
});
@@ -23,7 +23,7 @@ const createGridTracksFromPeer = (
2323
...peer.screenShareVideoTrack,
2424
peerId: peer.id,
2525
isLocal: peer.isLocal,
26-
userName: peer.metadata.peer?.displayName,
26+
userName: peer.metadata.server?.username,
2727
isVadActive: peer.screenShareAudioTrack?.vadStatus === 'speech',
2828
aspectRatio: peer.screenShareVideoTrack.aspectRatio,
2929
});
@@ -33,8 +33,8 @@ const createGridTracksFromPeer = (
3333
};
3434

3535
export const parsePeersToTracks = (
36-
localPeer: PeerWithTracks<PeerMetadata> | null,
37-
remotePeers: PeerWithTracks<PeerMetadata>[],
36+
localPeer: PeerWithTracks<PeerMetadata, ServerMetadata> | null,
37+
remotePeers: PeerWithTracks<PeerMetadata, ServerMetadata>[],
3838
): GridTrack[] => [
3939
...(localPeer ? createGridTracksFromPeer(localPeer) : []),
4040
...remotePeers.flatMap(createGridTracksFromPeer),
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export type PeerMetadata = { displayName?: string };
2+
export type ServerMetadata = { username?: string };

0 commit comments

Comments
 (0)