Skip to content

Commit 7713b59

Browse files
marcjulianmarcjulian
committed
feat(splitpane,menu): add contentId
1 parent 0c2372e commit 7713b59

File tree

5 files changed

+40
-90
lines changed

5 files changed

+40
-90
lines changed

‎README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ Type part of a snippet, press enter, and the snippet unfolds.
164164
| `i-slides-options` | `<ion-slides>` w/ options |
165165
| `i-spinner` | `<ion-spinner>` |
166166
| `i-split-pane` | `<ion-split-pane>` |
167-
| `i-split-pane-advanced` | `<ion-split-pane>` w/ a menu including `<ion-header>`, `<ion-content>` and `<ion-footer>` |
168167
| `i-tab` | `<ion-tab>` |
169168
| `i-tab-bar` | `<ion-tab-bar>` |
170169
| `i-tab-button` | `<ion-tab-button>` connected to `<ion-tab>` |

‎snippets/angular/html.json‎

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@
762762
"ion-menu": {
763763
"prefix": "i-menu",
764764
"body": [
765-
"<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
765+
"<ion-menu contentId=\"${1:menu-content}\" menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
766766
"\t<ion-header>",
767767
"\t\t<ion-toolbar>",
768768
"\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
@@ -984,7 +984,7 @@
984984
"ion-reorder-group": {
985985
"prefix": "i-reorder-group",
986986
"body": [
987-
"<ion-reorder-group (ionItemReorder)=\"${1:doReorder}(\\$event)\" disabled=\"${2|true,false}\">",
987+
"<ion-reorder-group (ionItemReorder)=\"${1:doReorder}(\\$event)\" disabled=\"${2|true,false|}\">",
988988
"\t$0",
989989
"</ion-reorder-group>"
990990
],
@@ -1158,8 +1158,8 @@
11581158
"ion-split-pane": {
11591159
"prefix": "i-split-pane",
11601160
"body": [
1161-
"<ion-split-pane>",
1162-
"\t<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
1161+
"<ion-split-pane contentId=\"${1:menu-content}\" when=\"${2|xs,sm,md,lg,xl|}\" [disabled]=\"${3|true,false|}\" (ionSplitPaneVisible)=\"${4:onSplitPaneVisible}($event)\">",
1162+
"\t<ion-menu contentId=\"${1:menu-content}\" menuId=\"${1:avocadoMenu}\" side=\"${5|start,end|}\" type=\"${6|overlay,push,reveal|}\">",
11631163
"\t\t<ion-header>",
11641164
"\t\t\t<ion-toolbar>",
11651165
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
@@ -1169,33 +1169,11 @@
11691169
"\t\t\t${5:Awesome avocado content}",
11701170
"\t\t</ion-content>",
11711171
"\t</ion-menu>",
1172-
"\t<ion-router-outlet main></ion-router-outlet>",
1172+
"\t<ion-router-outlet id=\"${1:menu-content}\"></ion-router-outlet>",
11731173
"</ion-split-pane>"
11741174
],
11751175
"description": "<ion-split-pane>"
11761176
},
1177-
"ion-split-pane-advanced": {
1178-
"prefix": "i-split-pane-advanced",
1179-
"body": [
1180-
"<ion-split-pane>",
1181-
"\t<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
1182-
"\t\t<ion-header>",
1183-
"\t\t\t<ion-toolbar>",
1184-
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
1185-
"\t\t\t</ion-toolbar>",
1186-
"\t\t</ion-header>",
1187-
"\t\t<ion-content>",
1188-
"\t\t\t${5:Awesome avocado content}",
1189-
"\t\t</ion-content>",
1190-
"\t\t<ion-footer>",
1191-
"\t\t\t${6:Awesome avocado footer}",
1192-
"\t\t</ion-footer>",
1193-
"\t</ion-menu>",
1194-
"\t<ion-router-outlet main></ion-router-outlet>",
1195-
"</ion-split-pane>"
1196-
],
1197-
"description": "<ion-split-pane> w/ one complete menu"
1198-
},
11991177
"ion-tab-bar": {
12001178
"prefix": "i-tab-bar",
12011179
"body": [

‎snippets/react/html-tsx.json‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,5 +83,24 @@
8383
"<Route exact path=\"${1:RoutePath}\" render={() => <Redirect to=\"${2:RedirectToPath}\" /> />"
8484
],
8585
"description": "Route component to use within <IonRouterOutlet>, use to redirect to another path"
86+
},
87+
"ion-split-pane": {
88+
"prefix": "ir-split-pane",
89+
"body": [
90+
"<IonContent>",
91+
"\t<IonSplitPane contentId=\"${1:menuContent}\" when=\"${2|xs,sm,md,lg,xl|}\">",
92+
"\t\t<IonMenu contentId=\"${1:menuContent}\">",
93+
"\t\t\t<IonHeader>",
94+
"\t\t\t\t<IonToolbar>",
95+
"\t\t\t\t\t<IonTitle>${3:Menu}</IonTitle>",
96+
"\t\t\t\t</IonToolbar>",
97+
"\t\t\t</IonHeader>",
98+
"\t\t</IonMenu>",
99+
"",
100+
"\t\t<IonPage id=\"${1:menuContent}\"/>",
101+
"\t</IonSplitPane>",
102+
"</IonContent>"
103+
],
104+
"description": "<IonSplitPane>"
86105
}
87106
}

‎snippets/stencil/html-tsx.json‎

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -624,14 +624,14 @@
624624
"ion-menu": {
625625
"prefix": "i-menu",
626626
"body": [
627-
"<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
627+
"<ion-menu content-id=\"${1:menu-content}\" menuId=\"${2:avocadoMenu}\" side=\"${3|start,end|}\" type=\"${4|overlay,push,reveal|}\">",
628628
"\t<ion-header>",
629629
"\t\t<ion-toolbar>",
630-
"\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
630+
"\t\t\t<ion-title>${5:Awesome avocado menu}</ion-title>",
631631
"\t\t</ion-toolbar>",
632632
"\t</ion-header>",
633633
"\t<ion-content>",
634-
"\t\t${5:Awesome avocado content}",
634+
"\t\t${6:Awesome avocado content}",
635635
"\t</ion-content>",
636636
"</ion-menu>"
637637
],
@@ -964,48 +964,24 @@
964964
"ion-split-pane": {
965965
"prefix": "i-split-pane",
966966
"body": [
967-
"<ion-split-pane content-id=\"menu-content\">",
968-
"\t<ion-menu content-id=\"menu-content\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
967+
"<ion-split-pane content-id=\"${1:menu-content}\" when=\"${2|xs,sm,md,lg,xl|}\">",
968+
"\t<ion-menu content-id=\"${1:menu-content}\" side=\"${3|start,end|}\" type=\"${4|overlay,push,reveal|}\">",
969969
"\t\t<ion-header>",
970970
"\t\t\t<ion-toolbar>",
971-
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
971+
"\t\t\t\t<ion-title>${5:Awesome avocado menu}</ion-title>",
972972
"\t\t\t</ion-toolbar>",
973973
"\t\t</ion-header>",
974974
"\t\t<ion-content>",
975-
"\t\t\t${5:Awesome avocado content}",
975+
"\t\t\t${6:Awesome avocado content}",
976976
"\t\t</ion-content>",
977977
"\t</ion-menu>",
978-
"\t<ion-content id=\"menu-content\">",
978+
"\t<ion-content id=\"${1:menu-content}\">",
979979
"\t\t<h1>${6:Hello}</h1>",
980980
"\t</ion-content>",
981981
"</ion-split-pane>"
982982
],
983983
"description": "<ion-split-pane>"
984984
},
985-
"ion-split-pane-advanced": {
986-
"prefix": "i-split-pane-advanced",
987-
"body": [
988-
"<ion-split-pane content-id=\"menu-content\">",
989-
"\t<ion-menu content-id=\"menu-content\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
990-
"\t\t<ion-header>",
991-
"\t\t\t<ion-toolbar>",
992-
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
993-
"\t\t\t</ion-toolbar>",
994-
"\t\t</ion-header>",
995-
"\t\t<ion-content>",
996-
"\t\t\t${5:Awesome avocado content}",
997-
"\t\t</ion-content>",
998-
"\t\t<ion-footer>",
999-
"\t\t\t${6:Awesome avocado footer}",
1000-
"\t\t</ion-footer>",
1001-
"\t</ion-menu>",
1002-
"\t<ion-content id=\"menu-content\">",
1003-
"\t\t<h1>${6:Hello}</h1>",
1004-
"\t</ion-content>",
1005-
"</ion-split-pane>"
1006-
],
1007-
"description": "<ion-split-pane> w/ one complete menu"
1008-
},
1009985
"ion-tab-bar": {
1010986
"prefix": "i-tab-bar",
1011987
"body": [

‎snippets/vue/html.json‎

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -684,14 +684,14 @@
684684
"ion-menu": {
685685
"prefix": "i-menu",
686686
"body": [
687-
"<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
687+
"<ion-menu contentId=\"${1:menu-content}\" menuId=\"${2:avocadoMenu}\" side=\"${3|start,end|}\" type=\"${4|overlay,push,reveal|}\">",
688688
"\t<ion-header>",
689689
"\t\t<ion-toolbar>",
690-
"\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
690+
"\t\t\t<ion-title>${5:Awesome avocado menu}</ion-title>",
691691
"\t\t</ion-toolbar>",
692692
"\t</ion-header>",
693693
"\t<ion-content>",
694-
"\t\t${5:Awesome avocado content}",
694+
"\t\t${6:Awesome avocado content}",
695695
"\t</ion-content>",
696696
"</ion-menu>"
697697
],
@@ -1049,44 +1049,22 @@
10491049
"ion-split-pane": {
10501050
"prefix": "i-split-pane",
10511051
"body": [
1052-
"<ion-split-pane>",
1053-
"\t<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
1052+
"<ion-split-pane contentId=\"${1:menu-content}\" when=\"${2|xs,sm,md,lg,xl|}\">",
1053+
"\t<ion-menu contentId=\"${1:menu-content}\" menuId=\"${3:avocadoMenu}\" side=\"${4|start,end|}\" type=\"${5|overlay,push,reveal|}\">",
10541054
"\t\t<ion-header>",
10551055
"\t\t\t<ion-toolbar>",
1056-
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
1056+
"\t\t\t\t<ion-title>${6:Awesome avocado menu}</ion-title>",
10571057
"\t\t\t</ion-toolbar>",
10581058
"\t\t</ion-header>",
10591059
"\t\t<ion-content>",
1060-
"\t\t\t${5:Awesome avocado content}",
1060+
"\t\t\t${7:Awesome avocado content}",
10611061
"\t\t</ion-content>",
10621062
"\t</ion-menu>",
1063-
"\t<ion-router-outlet main></ion-router-outlet>",
1063+
"\t<ion-router-outlet id=\"${1:menu-content}\"></ion-router-outlet>",
10641064
"</ion-split-pane>"
10651065
],
10661066
"description": "<ion-split-pane>"
10671067
},
1068-
"ion-split-pane-advanced": {
1069-
"prefix": "i-split-pane-advanced",
1070-
"body": [
1071-
"<ion-split-pane>",
1072-
"\t<ion-menu menuId=\"${1:avocadoMenu}\" side=\"${2|start,end|}\" type=\"${3|overlay,push,reveal|}\">",
1073-
"\t\t<ion-header>",
1074-
"\t\t\t<ion-toolbar>",
1075-
"\t\t\t\t<ion-title>${4:Awesome avocado menu}</ion-title>",
1076-
"\t\t\t</ion-toolbar>",
1077-
"\t\t</ion-header>",
1078-
"\t\t<ion-content>",
1079-
"\t\t\t${5:Awesome avocado content}",
1080-
"\t\t</ion-content>",
1081-
"\t\t<ion-footer>",
1082-
"\t\t\t${6:Awesome avocado footer}",
1083-
"\t\t</ion-footer>",
1084-
"\t</ion-menu>",
1085-
"\t<ion-router-outlet main></ion-router-outlet>",
1086-
"</ion-split-pane>"
1087-
],
1088-
"description": "<ion-split-pane> w/ one complete menu"
1089-
},
10901068
"ion-tab-bar": {
10911069
"prefix": "i-tab-bar",
10921070
"body": [

0 commit comments

Comments
 (0)