Skip to content

Commit d1298e3

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 82d869a commit d1298e3

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

firebird_db/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ The connector maintains tables as defined in the `schema.py` file:
1010

1111
## Requirements
1212

13-
- [Supported Python versions](https://github.com/fivetran/fivetran-csdk-connectors/blob/main/README.md#requirements)
13+
- [Supported Python versions](https://github.com/fivetran/fivetran-csdk-connectors/blob/main/README.md#requirements)
1414
- Operating system:
15-
- Windows 10 or later
16-
- macOS 13 (Ventura) or later
15+
- Windows: 10 or later (64-bit only)
16+
- macOS: 13 (Ventura) or later (Apple Silicon [arm64] or Intel [x86_64])
1717
- Linux: Distributions such as Ubuntu 20.04 or later, Debian 10 or later, or Amazon Linux 2 or later (arm64 or x86_64)
1818

1919
## Getting started

gnews/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ This connector does not require any additional packages beyond those provided by
6464
- Data normalization: `normalize_articles` flattens each `articles[*]` object and maps:
6565
- `image``urlToImage` (to keep parity with existing schema/column names
6666
- Persists only scalar fields (nested values are JSON-encoded strings)
67-
- Upserts: Each record is written via `op.upsert(...)` to `NEWS_STORIES`.
67+
- Upserts: Each record is written via `op.upsert(...)` to `news_stories`.
6868
- Stop conditions: `fetch_all_news` stops when:
6969
- Fewer than `page_size` results are returned, or
7070
- `page * page_size >= totalArticles`, or
@@ -78,7 +78,7 @@ This connector does not require any additional packages beyond those provided by
7878

7979
## Tables created
8080

81-
The connector creates the `NEWS_STORIES` table.
81+
The connector creates the `news_stories` table.
8282

8383
### NEWS_STORIES
8484

0 commit comments

Comments
 (0)