Skip to content

Commit c12dc44

Browse files
Feature/sunset full statement version (#109)
* feature/sunset-full-statement-version * add consistency tests * add auto release and update pr template * add auto release and update pr template * update consistency tests * revisions from review * update changelog and macro * regen docs * update readme and issue templates * updates from review * update default vars * update changelog * Update .github/ISSUE_TEMPLATE/bug-report.yml Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com> --------- Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
1 parent 01eed3a commit c12dc44

34 files changed

+221
-358
lines changed

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
name: 🐞 Bug
2-
description: Report a bug or an issue you've found within the dbt package
1+
name: 🐞 Bug (non-SQL-translation issues only)
2+
description: Report a bug or an issue you've found within the dbt package. For SQL translation issues, please contact [Fivetran Support](https://support.fivetran.com/).
33
title: "[Bug] <title>"
44
labels: ["bug", "triage"]
55
body:

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
contact_links:
2-
- name: Ask a question during our office hours
3-
url: https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours
4-
about: Schedule time during the external office hours block with the Fivetran Analytics Engineering team for support
2+
- name: SQL Translation Issues
3+
about: This dbt package only materializes the sql code provided in the `fivetran_formula_model` table and has no control over the translations themselves. For translation issues, please contact Fivetran Support.
4+
url: https://support.fivetran.com/hc/
5+
- name: Provide feedback or request a new package to our dbt package team
6+
url: https://www.surveymonkey.com/r/DQ7K7WW
7+
about: Fill out our survey form to provide valuable feedback to the Fivetran team developing and maintaining the dbt packages.
58
- name: Fivetran connector question
69
url: https://support.fivetran.com/hc
710
about: Have a question about your connector? Check out the Fivetran support portal for more details.

.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md

Lines changed: 11 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,48 +4,27 @@
44
**This PR will result in the following new package version:**
55
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? -->
66

7-
**Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:**
7+
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:**
8+
<!--- Copy/paste the CHANGELOG for this version below. -->
89

910
## PR Checklist
1011
### Basic Validation
1112
Please acknowledge that you have successfully performed the following commands locally:
12-
- [ ] dbt compile
13-
- [ ] dbt run –full-refresh
14-
- [ ] dbt run
15-
- [ ] dbt test
16-
- [ ] dbt run –vars (if applicable)
13+
- [ ] dbt run –full-refresh && dbt test
14+
- [ ] dbt run (if incremental models are present) && dbt test
1715

1816
Before marking this PR as "ready for review" the following have been applied:
19-
- [ ] The appropriate issue has been linked and tagged
20-
- [ ] You are assigned to the corresponding issue and this PR
17+
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18+
- [ ] All necessary documentation and version upgrades have been applied
19+
<!--- Be sure to update the package version in the dbt_project.yml, integration_tests/dbt_project.yml, and README if necessary. -->
20+
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
2121
- [ ] BuildKite integration tests are passing
22+
- [ ] Detailed validation steps have been provided below
2223

2324
### Detailed Validation
24-
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
25-
- [ ] You have validated these changes and assure this PR will address the respective Issue/Feature.
26-
- [ ] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
27-
- [ ] You have provided details below around the validation steps performed to gain confidence in these changes.
25+
Please share any and all of your validation steps:
2826
<!--- Provide the steps you took to validate your changes below. -->
2927

30-
### Standard Updates
31-
Please acknowledge that your PR contains the following standard updates:
32-
- Package versioning has been appropriately indexed in the following locations:
33-
- [ ] indexed within dbt_project.yml
34-
- [ ] indexed within integration_tests/dbt_project.yml
35-
- [ ] CHANGELOG has individual entries for each respective change in this PR
36-
<!--- If there is a parallel upstream change, remember to reference the corresponding CHANGELOG as an individual entry. -->
37-
- [ ] README updates have been applied (if applicable)
38-
<!--- Remember to check the following README locations for common updates. →
39-
<!--- Suggested install range (needed for breaking changes) →
40-
<!--- Dependency matrix is appropriately updated (if applicable) →
41-
<!--- New variable documentation (if applicable) -->
42-
- [ ] DECISIONLOG updates have been updated (if applicable)
43-
- [ ] Appropriate yml documentation has been added (if applicable)
44-
45-
### dbt Docs
46-
Please acknowledge that after the above were all completed the below were applied to your branch:
47-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
48-
4928
### If you had to summarize this PR in an emoji, which would it be?
5029
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
51-
:dancer:
30+
:dancer:

.github/workflows/auto-release.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: 'auto release'
2+
on:
3+
pull_request:
4+
types:
5+
- closed
6+
branches:
7+
- main
8+
9+
jobs:
10+
call-workflow-passing-data:
11+
if: github.event.pull_request.merged
12+
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
13+
secrets: inherit

CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,22 @@
1+
# dbt_salesforce_formula_utils v0.10.0
2+
[PR #109](https://github.com/fivetran/dbt_salesforce_formula_utils/pull/109) includes the following updates:
3+
4+
## 🚨 Breaking Changes 🚨
5+
- As announced in the [v0.9.2 August 2023 release](https://github.com/fivetran/dbt_salesforce_formula_utils/releases/tag/v0.9.2), the `full_statement_version=false` parameter has been fully deprecated from the `sfdc_formula_view` macro. Please remove any references to this parameter to avoid errors.
6+
- Additionally, the `reserved_table_name` and `fields_to_include` parameters have also been deprecated and should be removed.
7+
- The following macros have also been removed:
8+
- `sfdc_current_formula_values`
9+
- `sfdc_formula_pivot`
10+
- `sfdc_formula_refactor`
11+
- `sfdc_formula_view_fields`
12+
- `sfdc_formula_view_sql`
13+
- `sfdc_get_formula_column_values`
14+
- `sfdc_star_exact`
15+
16+
## Under the hood
17+
- Included auto-releaser GitHub Actions workflow to automate future releases.
18+
- Updated maintainer pull request template.
19+
120
# dbt_salesforce_formula_utils v0.9.3
221
[PR #101](https://github.com/fivetran/dbt_salesforce_formula_utils/pull/101) includes the following updates:
322

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ The [`sfdc_formula_view`](https://github.com/fivetran/dbt_salesforce_formula_uti
2828
```yml
2929
packages:
3030
- package: fivetran/salesforce_formula_utils
31-
version: [">=0.9.0", "<0.10.0"] # we recommend using ranges to capture non-breaking changes automatically
31+
version: [">=0.10.0", "<0.11.0"] # we recommend using ranges to capture non-breaking changes automatically
3232
```
3333
3434
## Step 3: Define required source tables
@@ -101,7 +101,7 @@ This macro generates the final sql needed to join the Salesforce formula fields
101101
----
102102

103103
## sfdc_formula_model_automation.sh ([source](https://github.com/fivetran/dbt_salesforce_formula_utils/blob/main/sfdc_formula_model_automation.sh))
104-
This bash script is intended to be used in order to automatically create the desired salesforce models via the command line within your dbt project. This bash script will generate a model file within your dbt project that contains the [sfdc_formula_view](https://github.com/fivetran/dbt_salesforce_formula_utils/blob/main/macros/sfdc_formula_view.sql) macro for the appropriately defined table(s). In order for this command to work you must be within the root directory of your dbt project.
104+
This bash script is intended to be used in order to automatically create the desired salesforce models via the command line within your dbt project. This bash script will generate a model file within your dbt project that contains the [sfdc_formula_view](https://github.com/fivetran/dbt_salesforce_formula_utils/blob/main/macros/sfdc_formula_view.sql) macro for the appropriately defined table(s). In order for this command to work you must be within the root directory of your dbt project. Note that this script is designed for dbt Core and is **not** compatible with dbt Cloud.
105105

106106
**Usage:**
107107
```bash

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
name: 'salesforce_formula_utils'
2-
version: '0.9.3'
2+
version: '0.10.0'
33
config-version: 2
44
require-dbt-version: [">=1.3.0", "<2.0.0"]

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/index.html

Lines changed: 8 additions & 8 deletions
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)