Part of #12128.
What to do
Five exclude patterns under [tool.mypy] in pyproject.toml name test paths that already
check clean. Remove them and regenerate the relaxation inventory in the same change. No test
file needs editing — this is a configuration-only pull request, and the smallest unit of the
parent effort.
Where
pyproject.toml — remove these five entries from the exclude list:
'tests/integration/docusaurus/deployment_patterns',
'tests/integration/docusaurus/tutorials',
'tests/integration/fixtures/yellow_tripdata_pandas_fixture',
'tests/performance',
'tests/validator/test_metric_configuration\.py',
scripts/mypy_relaxation_inventory.json — regenerate it with the guard's own emit mode in
the same commit. It is machine-generated; never hand-edit it.
How to verify
pip install -r requirements-types.txt -r reqs/requirements-dev-contrib.txt
# delete the five lines above from pyproject.toml, then:
python scripts/mypy_config_guard.py --emit-inventory > scripts/mypy_relaxation_inventory.json
invoke type-check --ci --pretty
Before: Success: no issues found in 783 source files (measured at 2c4123fa9).
After: Success: no issues found in 786 source files — three more modules, zero errors.
If your count differs by a few, develop has moved; what matters is that it went up and the
run stayed green.
Requirements
- When the type-check runs on the merged change, it reports zero errors and none of the five
patterns above remains in pyproject.toml.
- The checked-file count must increase, observed by comparing the
Success: line before and
after — a removal that does not raise the count means the pattern was matching nothing that
the check roots reach.
scripts/mypy_relaxation_inventory.json must be regenerated by
python scripts/mypy_config_guard.py --emit-inventory in the same commit, and the guard
must pass.- No file under
tests/ or great_expectations/ may change. If removing a pattern turns out
to surface an error, that pattern belongs to a sibling issue — leave it in place and comment
here.
- No new
exclude pattern may be added, including a narrower replacement for one removed.
Out of scope: every other exclude pattern, including the ones naming paths under
great_expectations/; the follow_imports = 'silent' override block; any mypy strictness
flag; any edit to a test file.
Notes
tests/performance and tests/integration/fixtures/yellow_tripdata_pandas_fixture match no
Python file at all — the first directory holds only shell scripts and JSON, the second no
longer exists. Removing them is pure cleanup and moves the count by zero.- The other three cover one module each: two package
__init__.py files and
tests/validator/test_metric_configuration.py.
Part of #12128.
What to do
Five
excludepatterns under[tool.mypy]inpyproject.tomlname test paths that alreadycheck clean. Remove them and regenerate the relaxation inventory in the same change. No test
file needs editing — this is a configuration-only pull request, and the smallest unit of the
parent effort.
Where
pyproject.toml— remove these five entries from theexcludelist:scripts/mypy_relaxation_inventory.json— regenerate it with the guard's own emit mode inthe same commit. It is machine-generated; never hand-edit it.
How to verify
Before:
Success: no issues found in 783 source files(measured at2c4123fa9).After:
Success: no issues found in 786 source files— three more modules, zero errors.If your count differs by a few, develop has moved; what matters is that it went up and the
run stayed green.
Requirements
patterns above remains in
pyproject.toml.Success:line before andafter — a removal that does not raise the count means the pattern was matching nothing that
the check roots reach.
scripts/mypy_relaxation_inventory.jsonmust be regenerated bypython scripts/mypy_config_guard.py --emit-inventoryin the same commit, and the guardmust pass.
tests/orgreat_expectations/may change. If removing a pattern turns outto surface an error, that pattern belongs to a sibling issue — leave it in place and comment
here.
excludepattern may be added, including a narrower replacement for one removed.Out of scope: every other
excludepattern, including the ones naming paths undergreat_expectations/; thefollow_imports = 'silent'override block; any mypy strictnessflag; any edit to a test file.
Notes
tests/performanceandtests/integration/fixtures/yellow_tripdata_pandas_fixturematch noPython file at all — the first directory holds only shell scripts and JSON, the second no
longer exists. Removing them is pure cleanup and moves the count by zero.
__init__.pyfiles andtests/validator/test_metric_configuration.py.