Merge pull request #353 from Sensing-Dev/update/node-name-v1.8

Update/add node name for 1.8.x

Author: Fixstars-momoko

.github/workflows/linux.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     branches:
       - main
+      - release/**
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
@@ -15,7 +16,7 @@ jobs:
     # well on Windows or Mac.  You can convert this to a matrix build if you need
     # cross-platform coverage.
     # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
       - uses: actions/checkout@v4

.github/workflows/macos.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     branches:
       - main
+      - release/**
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

.github/workflows/windows.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     branches:
       - main
+      - release/**
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

include/ion/port.h

@@ -166,7 +166,7 @@ class Port {
                              [&](const Port::Channel& c) { return std::get<0>(c) == nid; });
     }
 
-    void determine_succ(const NodeID& nid, const std::string& old_pn, const std::string& new_pn);
+    void determine_succ(const std::string & n_name, const NodeID &nid, const std::string &old_pn, const std::string &new_pn);
 
     /**
      * Overloaded operator to set the port index and return a reference to the current port. eg. port[0]

src/lower.cc

@@ -124,7 +124,7 @@ void determine_and_validate(std::vector<Node>& nodes) {
                     throw std::runtime_error(msg);
                 }
 
-                port.determine_succ(n.id(), pn, arginfo.name);
+                port.determine_succ(n.name(), n.id(), pn, arginfo.name);
                 pn = arginfo.name;
             }
 

src/port.cc

@@ -16,14 +16,14 @@ Port::Impl::Impl(const NodeID & nid, const std::string& pn, const Halide::Type&
     params[0] = Halide::Internal::Parameter(type, dimensions != 0, dimensions, argument_name(nid, pn, 0, gid));
 }
 
-void Port::determine_succ(const NodeID& nid, const std::string& old_pn, const std::string& new_pn) {
+void Port::determine_succ(const std::string & n_name,const NodeID &nid, const std::string &old_pn, const std::string &new_pn) {
     auto it = std::find(impl_->succ_chans.begin(), impl_->succ_chans.end(), Channel{nid, old_pn});
     if (it == impl_->succ_chans.end()) {
         log::error("fixme");
         throw std::runtime_error("fixme");
     }
 
-    log::debug("Determine free port {} as {} on Node {}", old_pn, new_pn, nid.value());
+    log::debug("Determine free port {} as {} on Node: {}_{}", old_pn, new_pn, n_name, nid.value());
     impl_->succ_chans.erase(it);
     impl_->succ_chans.insert(Channel{nid, new_pn});
 }