fix: resolve test parameterization bugs in unified test runner

- Fix direction mapping in main.cpp: forward=-1 (FLAGFFT_FORWARD), inverse=1
- Fix default direction in TestParams: 0 means no filter (was -1)
- Fix binary name construction in run_tests.py:
  - 2D tests use single binary test_2d_correctness
  - 1D tests use test_exec_{type}_{direction}_{algo}_{batch_mode}
- All 22 operators now pass accuracy tests (CT: 8, BS: 8, 2D: 6)

Author: Artlesbol

ctest/flagfft_test.h

@@ -664,7 +664,7 @@ struct TestParams {
   int nx = 0;           // 0 = use default size arrays
   int ny = 0;           // 0 = use default size arrays
   int batch = 0;        // 0 = use default batch arrays
-  int direction = -1;   // -1 = all directions, 0 = forward, 1 = inverse
+  int direction = 0;    // 0 = all directions (no filter), -1 = forward, 1 = inverse
   double scale = -1.0;  // -1 = use default scales
   bool json_output = false;
   const char* json_file = nullptr;
@@ -711,8 +711,8 @@ inline std::vector<Test1DParam> override_params(std::vector<Test1DParam> default
 }
 
 inline bool should_skip_direction(int direction_flag) {
-  // direction_flag: FLAGFFT_FORWARD=0, FLAGFFT_INVERSE=1
-  if (g_test_params.direction < 0) return false;  // -1 = don't filter
+  // direction_flag: FLAGFFT_FORWARD=-1, FLAGFFT_INVERSE=1
+  if (g_test_params.direction == 0) return false;  // 0 = no filter (unset)
   return g_test_params.direction != direction_flag;
 }
 

ctest/main.cpp

@@ -23,9 +23,9 @@ int main(int argc, char** argv) {
     } else if (strncmp(argv[i], "--direction=", 12) == 0) {
       const char* dir = argv[i] + 12;
       if (strcmp(dir, "forward") == 0 || strcmp(dir, "fwd") == 0)
-        g_test_params.direction = 0;
+        g_test_params.direction = -1;  // FLAGFFT_FORWARD
       else if (strcmp(dir, "inverse") == 0 || strcmp(dir, "inv") == 0)
-        g_test_params.direction = 1;
+        g_test_params.direction = 1;  // FLAGFFT_INVERSE
     } else if (strncmp(argv[i], "--scale=", 8) == 0) {
       g_test_params.scale = atof(argv[i] + 8);
     } else if (strncmp(argv[i], "--json-file=", 12) == 0) {

tools/run_tests.py

@@ -117,9 +117,37 @@ def parse_args() -> argparse.Namespace:
 
 # Test execution functions
 
+# Operators that include direction (fwd/inv) in their binary name
+_OPS_WITH_DIRECTION = {"c2c", "z2z"}
+
 
 def build_accuracy_cmd(case: dict, build_dir: Path) -> tuple[list[str], str]:
-    binary = build_dir / "ctest" / case["ctest"]
+    # Build binary name based on algorithm:
+    # - 2D tests use a single binary: test_2d_correctness
+    # - 1D tests: test_exec_{type}_{direction}_{algo}_{batch_mode}
+    #   For types with direction (c2c, z2z): include fwd/inv
+    #   For types without direction (r2c, c2r, d2z, z2d, r2c_c2r, d2z_z2d): no direction
+    #   batch_mode: batch=1 -> _s, batch>1 -> _b
+    ctest_base = case["ctest"]
+    algo = case["algo"]
+
+    if algo == "2d":
+        # 2D tests use a single binary for all types
+        binary_name = ctest_base
+    else:
+        batch_mode = "s" if case["batch"] == 1 else "b"
+        # Check if this operator has direction in binary name
+        # Extract the type prefix from op_id (e.g., "c2c_1d" -> "c2c")
+        type_prefix = case["op_id"].split("_")[0]
+        has_direction = type_prefix in _OPS_WITH_DIRECTION
+
+        if has_direction:
+            dir_str = "fwd" if case["direction"] == "forward" else "inv"
+            binary_name = f"{ctest_base}_{dir_str}_{algo}_{batch_mode}"
+        else:
+            binary_name = f"{ctest_base}_{algo}_{batch_mode}"
+
+    binary = build_dir / "ctest" / binary_name
     cmd = [str(binary), f"--nx={case['nx']}"]
     if case["rank"] == 2:
         cmd.append(f"--ny={case['ny']}")