add unit test

ABTastyAdel · ABTastyAdel · commit 60e58d25e1e9 · 2025-07-09T18:24:54.000+02:00
diff --git a/lib/visitor.dart b/lib/visitor.dart
@@ -349,7 +349,6 @@ class Visitor with EmotionAiDelegate {
 
   // Get consent
   bool getConsent() {
-    sessionDuration = DateTime.now();
     return _hasConsented;
   }
 
diff --git a/lib/visitor/strategy/default_strategy.dart b/lib/visitor/strategy/default_strategy.dart
@@ -43,7 +43,7 @@ class DefaultStrategy implements IVisitor {
   }
 
   // Activate
-  Future<void> _sendActivate(
+  /*  Future<void> _sendActivate(
       Modification pModification, bool isDuplicated) async {
     // Check if the callback is defined
     ExposedFlag? exposedFlag;
@@ -97,6 +97,81 @@ class DefaultStrategy implements IVisitor {
                 " status code = ${activateResponse.statusCode.toString()}");
       }
     });
+  } */
+
+  Future<void> _sendActivate(
+    Modification modification,
+    bool isDuplicated,
+  ) async {
+    // Getconfig et le callback
+    final config = Flagship.sharedInstance().getConfiguration();
+    final onExposed = config?.onVisitorExposed;
+
+    // Prepare exposure object
+    ExposedFlag? exposedFlag;
+    VisitorExposed? exposedVisitor;
+    if (onExposed != null) {
+      exposedFlag = ExposedFlag(
+        modification.key,
+        modification.value,
+        modification.defaultValue,
+        FlagMetadata.withMap(modification.toJsonInformation()),
+      );
+      exposedVisitor = VisitorExposed(
+        visitor.visitorId,
+        visitor.anonymousId,
+        visitor.getContext(),
+      );
+    }
+
+    // When deduplicated
+    if (isDuplicated) {
+      if (onExposed != null && exposedFlag != null && exposedVisitor != null) {
+        exposedFlag.alreadyActivatedCampaign = true;
+        onExposed(exposedVisitor, exposedFlag);
+      }
+      print('Skip the activate: Flag already activated.');
+      return;
+    }
+
+    // When not duplicated
+    final String? flagJson =
+        exposedFlag != null ? jsonEncode(exposedFlag) : null;
+    final String? visitorJson =
+        exposedVisitor != null ? jsonEncode(exposedVisitor) : null;
+
+    final activateHit = Activate(
+      modification,
+      visitor.visitorId,
+      visitor.anonymousId,
+      Flagship.sharedInstance().envId ?? '',
+      flagJson,
+      visitorJson,
+    );
+
+    // Log interne pour troubleshooting
+    DataUsageTracking.sharedInstance().processTroubleShootingHits(
+      CriticalPoints.VISITOR_SEND_ACTIVATE.name,
+      visitor,
+      activateHit,
+    );
+
+    // Envoi du hit
+    try {
+      final response = await visitor.trackingManager?.sendActivate(activateHit);
+      final status = response?.statusCode ?? -1;
+      if (status < 200 || status >= 300) {
+        Flagship.logger(
+          Level.ERROR,
+          'ACTIVATE_FAILED: status code = $status',
+        );
+      }
+    } catch (e, stack) {
+      Flagship.logger(
+        Level.ERROR,
+        'ACTIVATE_FAILED: exception = $e\n$stack',
+      );
+    }
   }
 
   @override
diff --git a/lib/visitor/visitor_delegate.dart b/lib/visitor/visitor_delegate.dart
@@ -9,6 +9,7 @@ import 'package:flagship/visitor/strategy/no_consent_strategy.dart';
 import 'package:flagship/visitor/strategy/not_ready_strategy.dart';
 import 'package:flagship/visitor/strategy/panic_strategy.dart';
 import 'package:flagship/flagship.dart';
+import 'package:flutter/material.dart';
 import '../visitor.dart';
 
 class VisitorDelegate implements IVisitor {
@@ -149,7 +150,6 @@ class VisitorDelegate implements IVisitor {
         "--------- Session time duration is ${elapsed.inSeconds} ------------");
 
     try {
-      // -- 1. Session expirée ---------------------------------------------------
       if (elapsed > FSSessionVisitor) {
         _activatedVariations
           ..clear()
diff --git a/test/activate_test.dart b/test/activate_test.dart
@@ -1,23 +1,44 @@
+import 'package:flagship/api/service.dart';
+import 'package:flagship/cache/default_cache.dart';
+import 'package:flagship/decision/api_manager.dart';
 import 'package:flagship/flagship.dart';
 import 'package:flagship/flagship_config.dart';
+import 'package:flagship/flagship_version.dart';
 import 'package:flagship/model/exposed_flag.dart';
 import 'package:flagship/model/flag.dart';
 import 'package:flagship/model/modification.dart';
 import 'package:flagship/model/visitor_exposed.dart';
+import 'package:flagship/tracking/tracking_manager.dart';
+import 'package:flagship/tracking/tracking_manager_config.dart';
+import 'package:flagship/tracking/tracking_manager_continuous_strategies.dart';
 import 'package:flagship/visitor/strategy/default_strategy.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:flagship/hits/activate.dart';
+import 'package:mockito/annotations.dart';
+import 'package:mockito/mockito.dart';
 import 'package:path_provider_platform_interface/path_provider_platform_interface.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 import 'fake_path_provider_platform.dart';
 import 'test_tools.dart';
+import 'package:http/http.dart' as http;
+import 'service_test.mocks.dart';
+import 'test_tools.dart';
 
+@GenerateMocks([Service])
 void main() {
-  WidgetsFlutterBinding.ensureInitialized();
+  MockService fakeService = MockService();
+
+  MockService fakeTrackingService = MockService();
+
+  TrackingManager fakeTrackingMgr = TrackingManageContinuousStrategy(
+      fakeTrackingService, TrackingManagerConfig(), DefaultCacheHitImp());
+
+  ApiManager fakeApi = ApiManager(fakeService);
   PathProviderPlatform.instance = FakePathProviderPlatform();
   ToolsTest.sqfliteTestInit();
+  WidgetsFlutterBinding.ensureInitialized();
   SharedPreferences.setMockInitialValues({});
 
   test("Activate with Modification object ", () {
@@ -111,4 +132,51 @@ void main() {
     var eF = ExposedFlag("key", 12, 12, FlagMetadata.withMap({}));
     expect(eF.metadata().campaignId, "");
   });
+
+  test(' Test is Deduplicated', () async {
+    /// prepare response
+    when(fakeTrackingService.sendHttpRequest(RequestType.Post,
+            'https://decision.flagship.io/v2/activate', any, any,
+            timeoutMs: TIMEOUT_REQUEST))
+        .thenAnswer((_) async {
+      return http.Response("mock", 200);
+    });
+
+    var testConfig = ConfigBuilder().withOnVisitorExposed((v, f) {
+      if (v.id == "testV") {
+        expect(f.metadata().campaignId, "campaignId");
+        expect(v.id, "expoVisitorObj");
+        expect(f.alreadyActivatedCampaign, true);
+      }
+    }).build();
+
+    Flagship.start("bkk9glocmjcg0vtmdlrr", "apiKey", config: testConfig);
+
+    var testV = Flagship.newVisitor(visitorId: "testV", hasConsented: true)
+        .withContext({"expoKey": "expoVal"}).build();
+
+    testV.trackingManager = fakeTrackingMgr;
+    testV.config.decisionManager = fakeApi;
+
+    // Create a default strategy
+    var dfltStrategy = DefaultStrategy(testV);
+
+    Modification itemModif = Modification(
+        "key1",
+        "campaignId",
+        "campName",
+        "variationGroupId",
+        "vargName",
+        "variationId",
+        "varName",
+        true,
+        "ab",
+        "slug",
+        12);
+
+    dfltStrategy.activateFlag(itemModif, isDuplicated: true);
+    var tr = dfltStrategy.visitor.trackingManager
+        as TrackingManageContinuousStrategy;
+    expect(tr.activatePool.fsQueue.length, 0);
+  });
 }
diff --git a/test/tracking_manager_test.dart b/test/tracking_manager_test.dart
@@ -85,6 +85,8 @@ Future<void> main() async {
       mockFlag = vMock.getFlag("key_A");
       var mockVal = mockFlag.value("defaultValue", visitorExposed: false);
       expect(mockVal, "val_A");
+      vMock.sessionDuration =
+          DateTime.now().subtract(const Duration(minutes: 35));
       await mockFlag.visitorExposed();
     }
 
@@ -105,7 +107,10 @@ Future<void> main() async {
     mockFlagBis = vMock.getFlag("key_A");
     var mockValBis = mockFlagBis.value("defaultValue", visitorExposed: false);
     expect(mockValBis, "val_A");
+    vMock.sessionDuration =
+        DateTime.now().subtract(const Duration(minutes: 35));
     await mockFlagBis.visitorExposed();
+
     // After sucess the pool should be empty
     expect(
         (vMock.trackingManager as TrackingManageContinuousStrategy)

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,6 @@ class Visitor with EmotionAiDelegate {`
`349`	`349`
`350`	`350`	`// Get consent`
`351`	`351`	`bool getConsent() {`
`352`		`- sessionDuration = DateTime.now();`
`353`	`352`	`return _hasConsented;`
`354`	`353`	`}`
`355`	`354`