ensure thrinfo is valid at the end of bli_l3_sup_thread_decorator_entry#920
Open
chillenb wants to merge 2 commits intoflame:masterfrom
Open
ensure thrinfo is valid at the end of bli_l3_sup_thread_decorator_entry#920chillenb wants to merge 2 commits intoflame:masterfrom
chillenb wants to merge 2 commits intoflame:masterfrom
Conversation
chillenb
force-pushed
the
nouseafterfree
branch
from
f0ff7cd to
6b0df7a
Compare
Author
|
I decided to do it a different way (less invasive, fewer changes)
void bli_l3_sup_thrinfo_update
(
const rntm_t* rntm,
thrinfo_t** root
);to void bli_l3_sup_thrinfo_update
(
const rntm_t* rntm,
thrinfo_t* root
);to reflect the fact that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #919. I'm not too familiar with the codebase, so I'm not sure if the barrier at the end of
bli_l3_sup_thread_decorator_entryneeds to use the original thrinfo or after modification inside bli_gemmsup_int / bli_gemmtsup_int.