Improvement to the pin tool

[hosiet]

Currently flameshot provides a simple implementation of image pinning. However, this implementation is quite simple. Once the image is pinned, it floats at the top of the desktop and can be dragged around, but that's basically everything. In order to close this pinned image, one will have to use the "Esc" key or double click on the image. Otherwise the only possible way is to close from the window list. This is not friendly to tablet users who have limited access to the keyboard.

I think the following improvements can be made:

• Allow right click on the pinned image; a menu should pop out giving options to close the pinned image or save it as an image file on disk.
• Document the usage of pin tool somewhere. I doubt users ever know the behavior of "double click to close".

[borgmanJeremy]

This sounds like a great idea.

1. Will right click work well on tablets? We have gotten a fair amount of feedback when features do not work well on touch interfaces. Perhaps a long press would activate it?

2. For demonstrating the new features I think we can tie in a "Tip of the Day" to the welcome screen @mmahmoudian is working on.

[hosiet]

1: I had some touchscreen laptops in the past; at least on Windows a long press will be automatically interpreted as right click.

2: That looks too heavy to me. We are not a full-featured IDE with tip-of-the-day window on startup...

[borgmanJeremy]

Okay lets start working on just the menu part and for the tip of the day stuff we can discuss on #887

[mmahmoudian]

I myself didn't know that double click works on pinned image.
it is clear that we suffer from poor documentation. the website should be also re-structured to have a dedicated section for UI and CLI.

About tip of the day, I agree that might be over-doing it, but I can also see some merits in it. The main question is how heavy would it get it we implement that in the welcome screen? if there is a dedicated box to show two lines of text randomly chosen from a pool.

[holazt]

About the advanced features of Pin tools:

1. right-click to bring up the editing tools back.
2. accept external image drag and drop to replace the pinned image.
3. when the mouse wheel is scrolling and zooming, the pin widget shows the zoom percentage on the top left corner of the image.

[mmahmoudian]

@ZetaoYang I have flameshot-git (r576.f34def6-1 AUR) installed and none of the things you mentioned worked:

1. right-click did not bring up any tools (double-right-clicking closed the pined window)
2. drag and drop didn't work from Firefox and Pinta
3. mouse wheel change the zoom (this is also something I didn't know), but no percentage were shown anywhere

[holazt]

@ZetaoYang I have flameshot-git (r576.f34def6-1 AUR) installed and none of the things you mentioned worked:

1. right-click did not bring up any tools (double-right-clicking closed the pined window)
2. drag and drop didn't work from Firefox and Pinta
3. mouse wheel change the zoom (this is also something I didn't know), but no percentage were shown anywhere

I mean new features that flameshot can add in the future.

[mmahmoudian]

@ZetaoYang 😅 seems I got too excited too early

[AlexP11223]

I and others from #554 want a way to remove border. It is implemented in #622 but we did not find a good way so far to introduce such setting except adding a separate option in the app settings. Preferably without the need to set it manually for each pin every time. It is not possible to add it in the side panel via a tool-specific widget like for Text because pin activates immediately. And using the global thickness value is not ideal too because then we would need to adjust it all the time when choosing other tools.

[mmahmoudian]

I just realized that you cannot pin the image if the "close after capture" is on. Reported it as a [logical] bug in #964