fix: author search link

Author: flaming-codes

web/app/data/package.service.ts

@@ -4,7 +4,7 @@ import { Tables } from "./supabase.types.generated";
 import { supabase } from "./supabase.server";
 import { slog } from "../modules/observability.server";
 import { authorIdSchema } from "./author.shape";
-import { groupBy, uniqBy } from "es-toolkit";
+import { groupBy, omit, uniqBy } from "es-toolkit";
 import TTLCache from "@isaacs/ttlcache";
 import { format, hoursToMilliseconds } from "date-fns";
 import { embed } from "ai";
@@ -199,12 +199,12 @@ export class PackageService {
       ]);
 
     if (packageFTS.error) {
-      slog.error("Error in searchPackages", packageFTS.error);
+      slog.error("Error in searchPackages FTS", packageFTS.error);
       throw packageFTS.error;
     }
 
     if (packageExact.error) {
-      slog.error("Error in searchPackages", packageExact.error);
+      slog.error("Error in searchPackages Exact", packageExact.error);
       throw packageExact.error;
     }
 
@@ -217,20 +217,38 @@ export class PackageService {
 
     if (embeddingSimilarity) {
       if (embeddingSimilarity.error) {
-        slog.error("Error in searchPackages", embeddingSimilarity.error);
+        slog.error(
+          "Error in searchPackages Embeddings",
+          embeddingSimilarity.error,
+        );
       }
     }
 
+    // console.log(
+    //   "embeddingSimilarity",
+    //   embeddingSimilarity?.data?.map((x) => {
+    //     const { source_searchable_content, ...rest } = x;
+    //     return rest;
+    //   }),
+    // );
+
     // Prefer the exact match over the similarity match.
     // Therefore we filter out the similarity match if it's the same as the exact match.
     const sources = [
-      ...(embeddingFTS?.data || []),
       ...(embeddingSimilarity?.data || []),
-    ].filter((item) => {
-      const hasExactMatch =
-        packageExact.data && packageExact.data.id === item.cran_package_id;
-      return !hasExactMatch;
-    });
+      ...(embeddingFTS?.data || []),
+    ]
+      .filter((item) => {
+        const hasExactMatch =
+          packageExact.data && packageExact.data.id === item.cran_package_id;
+        return !hasExactMatch;
+      })
+      .map((item) => {
+        // Remove the source_searchable_content from the response
+        // for now, as it's quite a lot of text data that's not
+        // applied in the UI.
+        return omit(item, ["source_searchable_content"]);
+      });
 
     const lexical = uniqBy(packageFTS.data, (item) => item.id)
       .filter((item) => {
@@ -263,7 +281,7 @@ export class PackageService {
           .maybeSingle();
 
         if (error || !data) {
-          slog.error("Error in searchPackages", error);
+          slog.error("Error in searchPackages fetching package data", error);
           return null;
         }
 

web/app/modules/search.hit.tsx

@@ -2,6 +2,7 @@ import { Link } from "react-router";
 import { Database } from "../data/supabase.types.generated";
 import { Tag } from "./tag";
 import { PropsWithChildren, ReactNode } from "react";
+import { RiArrowRightUpLine } from "@remixicon/react";
 
 export type BaseSearchHit = { id: number; name: string; synopsis?: string };
 
@@ -62,11 +63,14 @@ export function PackageHit(props: {
             }
 
             const isInternal = refData.source_type === "internal";
+            const hasSource = Boolean(refData.source_url);
 
             const content = (
               <Tag size="sm" className="flex items-center gap-2 leading-none">
                 {sourceName}
-                {/* !isInternal ? <RiArrowRightUpLine size={12} /> : null */}
+                {!isInternal && hasSource ? (
+                  <RiArrowRightUpLine size={12} />
+                ) : null}
               </Tag>
             );
 
@@ -105,7 +109,7 @@ export function AuthorHit(props: { item: BaseSearchHit; onClick: () => void }) {
   return (
     <>
       <HitLink
-        to={`/package/${name}`}
+        to={`/author/${name}`}
         name={name}
         tag={<Tag borderGradients="jade">CRAN Author</Tag>}
         onClick={onClick}

web/app/modules/search.nav.tsx

@@ -7,7 +7,6 @@ import {
   RefObject,
   useCallback,
   useEffect,
-  useLayoutEffect,
   useRef,
   useState,
 } from "react";
@@ -65,7 +64,7 @@ export function NavSearch(props: Props) {
           action: "/api/search?index",
         });
       },
-      100,
+      150,
       {
         edges: ["trailing"],
       },
@@ -268,7 +267,7 @@ export function SearchResults(
 function useSyncedQueryHash() {
   const [q, setQ] = useState("");
 
-  useLayoutEffect(() => {
+  useEffect(() => {
     const getValue = () => {
       const hashes = new URLSearchParams(window.location.hash.replace("#", ""));
       return hashes.get("q") || "";

web/package.json

@@ -3,7 +3,7 @@
   "private": true,
   "sideEffects": false,
   "type": "module",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "scripts": {
     "postinstall": "npm run licenses.build",
     "postuninstall": "npm run licenses.build",
@@ -100,4 +100,4 @@
   "engines": {
     "node": ">=20.0.0"
   }
-}
+}