Skip to content

Commit 08e668c

Browse files
committed
skip some tests for now
1 parent 5d25b19 commit 08e668c

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

topology_test.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,12 @@ var _ = ginkgo.Describe("Topology behavior", func() {
8383
testTopologyJSON(TopologyOptions{Owner: "logistics-team"}, "fixtures/expectations/topology_tree_with_owner_filter.json")
8484
})
8585

86-
// ginkgo.It("Should test tree with type filter", func() {
87-
// testTopologyJSON(TopologyOptions{Types: []string{"Entity"}}, "fixtures/expectations/topology_tree_with_type_filter.json")
88-
// })
86+
ginkgo.It("Should test tree with type filter", func() {
87+
// FIXME:
88+
ginkgo.Skip("type filter is applied on Go side. The team list is already populated by the SQL query and later the component might be removed by the type filter.")
89+
90+
testTopologyJSON(TopologyOptions{Types: []string{"Entity"}}, "fixtures/expectations/topology_tree_with_type_filter.json")
91+
})
8992

9093
ginkgo.It("Should test tree with negative type filter", func() {
9194
// TODO: Change implementation of matchItems to fix this
@@ -94,9 +97,12 @@ var _ = ginkgo.Describe("Topology behavior", func() {
9497
testTopologyJSON(TopologyOptions{Types: []string{"!KubernetesCluster"}}, "fixtures/expectations/topology_tree_with_negative_type_filter.json")
9598
})
9699

97-
// ginkgo.It("Should test tree with status filter", func() {
98-
// testTopologyJSON(TopologyOptions{Status: []string{string(types.ComponentStatusWarning)}}, "fixtures/expectations/topology_tree_with_status_filter.json")
99-
// })
100+
ginkgo.It("Should test tree with status filter", func() {
101+
// FIXME:
102+
ginkgo.Skip("status filter is applied on Go side. The team list is already populated by the SQL query and later the component might be removed by the status filter.")
103+
104+
testTopologyJSON(TopologyOptions{Status: []string{string(types.ComponentStatusWarning)}}, "fixtures/expectations/topology_tree_with_status_filter.json")
105+
})
100106

101107
ginkgo.It("Should test tree with ID and status filter", func() {
102108
testTopologyJSON(TopologyOptions{ID: dummy.LogisticsAPI.ID.String(), Status: []string{string(types.ComponentStatusHealthy)}}, "fixtures/expectations/topology_tree_with_id_and_status_filter.json")

0 commit comments

Comments
 (0)