fix: fix pagination issues with in permissions view

chore: make improvements to permissions

Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Update src/components/Permissions/ManagePermissions/Forms/DeletePermission.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx

Co-authored-by: Moshe Immerman <[email protected]>

Author: mainawycliffe

src/api/services/permissions.ts

@@ -76,7 +76,11 @@ export function fetchPermissions(
 
   const url = `/permissions?${queryParam}&select=${selectFields.join(",")}&limit=${pageSize}&offset=${pageIndex * pageSize}`;
   return resolvePostGrestRequestWithPagination(
-    IncidentCommander.get<PermissionAPIResponse[]>(url)
+    IncidentCommander.get<PermissionAPIResponse[]>(url, {
+      headers: {
+        Prefer: "count=exact"
+      }
+    })
   );
 }
 

src/components/Permissions/ManagePermissions/Forms/DeletePermission.tsx

@@ -53,7 +53,7 @@ export default function DeletePermission({
       {isConfirmDialogOpen && (
         <ConfirmationPromptDialog
           title="Delete Permission"
-          description="Are you sure you want to permission?"
+          description="Are you sure you want to delete the permission?"
           onConfirm={onDeleteResource}
           isOpen={isConfirmDialogOpen}
           onClose={() => setIsConfirmDialogOpen(false)}

src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx

@@ -29,7 +29,7 @@ export default function FormikPermissionSelectResourceFields() {
   const { setFieldValue } = useFormikContext<Record<string, any>>();
 
   const [switchOption, setSwitchOption] = useState<
-    "Component" | "Catalog" | "Canary" | "Playbook" | "Connection" | "Object"
+    "Component" | "Catalog" | "Canary" | "Playbook" | "Connection" | "Global"
   >("Catalog");
 
   return (
@@ -43,7 +43,7 @@ export default function FormikPermissionSelectResourceFields() {
               "Component",
               "Connection",
               "Playbook",
-              "Object"
+              "Global"
             ]}
             className="w-auto"
             itemsClassName=""
@@ -89,7 +89,7 @@ export default function FormikPermissionSelectResourceFields() {
           <FormikConnectionField required name="connection_id" />
         )}
 
-        {switchOption === "Object" && (
+        {switchOption === "Global" && (
           <FormikSelectDropdown
             required
             name="object"

src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx

@@ -101,7 +101,7 @@ export default function PermissionForm({
       onClose={onClose}
       open={isOpen}
       bodyClass="flex flex-col w-full flex-1 h-full overflow-y-auto"
-      helpLink="/installation/saas/agent"
+      helpLink="/reference/permissions"
     >
       <div className="flex flex-1 flex-col gap-2">
         <Formik<Partial<PermissionTable>>
@@ -153,7 +153,7 @@ export default function PermissionForm({
                 name="action"
                 label="Action"
               />
-              <FormikCheckbox name="deny" label="Is deny action" />
+              <FormikCheckbox name="deny" label="Deny" />
               <FormikTextArea name="description" label="Description" />
             </div>
             <CanEditResource

src/components/Permissions/PermissionsView.tsx

@@ -67,7 +67,7 @@ export default function PermissionsView({
   }, [isLoading, setIsLoading]);
 
   const totalEntries = data?.totalEntries || 0;
-  const pageCount = totalEntries ? Math.ceil(totalEntries / pageSize) : -1;
+  const pageCount = totalEntries ? Math.ceil(totalEntries / pageSize) : 1;
   const permissions = data?.data || [];
 
   return (