fix: handle missing conditions for helm release (#190)

* fix: handle missing conditions for helm release

* chore: add json tags for status

* chore: revert old status map update

Author: yashmehrotra

pkg/health/status.go

@@ -25,8 +25,8 @@ func init() {
 
 type status struct {
 	Status struct {
-		Conditions []metav1.Condition
-	}
+		Conditions []metav1.Condition `json:"conditions"`
+	} `json:"status"`
 }
 
 type GenericStatus struct {
@@ -245,6 +245,7 @@ func GetHealthFromStatus(k GenericStatus, statusMap StatusMap) (*HealthStatus, e
 	health := &HealthStatus{
 		Health: HealthUnknown,
 	}
+
 	if len(statusMap.Conditions) == 0 {
 		return health, nil
 	}

pkg/health/testdata/Kubernetes/HelmRelease/flux-helmrelease-ready.yaml

@@ -0,0 +1,77 @@
+apiVersion: helm.toolkit.fluxcd.io/v2
+kind: HelmRelease
+metadata:
+  annotations:
+    kustomize/patched: "true"
+    expected-status: InstallSucceeded
+    expected-health: healthy
+    expected-ready: "true"
+  creationTimestamp: "2025-11-03T05:08:53Z"
+  finalizers:
+  - finalizers.fluxcd.io
+  generation: 1
+  labels:
+    canaries.flanksource.com/canary-id: ""
+    canaries.flanksource.com/check-id: ""
+  name: postgresql
+  namespace: default
+  resourceVersion: "6306"
+  uid: 108e19b3-7180-46f5-858a-0bc7da4afa65
+spec:
+  chart:
+    spec:
+      chart: postgresql
+      reconcileStrategy: ChartVersion
+      sourceRef:
+        kind: HelmRepository
+        name: bitnami-postgres
+        namespace: flux-system
+      version: 18.x
+  install:
+    createNamespace: true
+  interval: 5m
+  values:
+    auth:
+      database: exampledb
+      password: qwerty123
+      postgresPassword: qwerty123
+      username: admin
+    primary:
+      persistence:
+        enabled: false
+status:
+  conditions:
+  - lastTransitionTime: "2025-11-03T05:09:18Z"
+    message: Helm install succeeded for release default/postgresql.v1 with chart
+      [email protected]
+    observedGeneration: 1
+    reason: InstallSucceeded
+    status: "True"
+    type: Ready
+  - lastTransitionTime: "2025-11-03T05:09:18Z"
+    message: Helm install succeeded for release default/postgresql.v1 with chart
+      [email protected]
+    observedGeneration: 1
+    reason: InstallSucceeded
+    status: "True"
+    type: Released
+  helmChart: flux-system/default-postgresql
+  history:
+  - appVersion: 18.0.0
+    chartName: postgresql
+    chartVersion: 18.1.3
+    configDigest: sha256:22ee20aec85ec029ac57660ee91f9057303d0021d0ff666bd9e75c77a7591fbe
+    digest: sha256:af5d32477fea7f8972783ff68b61775412c8380dd518e3d55eeaeee2a0b5558d
+    firstDeployed: "2025-11-03T05:09:02Z"
+    lastDeployed: "2025-11-03T05:09:02Z"
+    name: postgresql
+    namespace: default
+    status: deployed
+    version: 1
+  lastAttemptedConfigDigest: sha256:22ee20aec85ec029ac57660ee91f9057303d0021d0ff666bd9e75c77a7591fbe
+  lastAttemptedGeneration: 1
+  lastAttemptedReleaseAction: install
+  lastAttemptedReleaseActionDuration: 16.793627689s
+  lastAttemptedRevision: 18.1.3
+  observedGeneration: 1
+  storageNamespace: default