IndexerClient: Ignore invalid transactions instead of crashing

Author: adg-flare

apps/ftso-data-provider/src/ftso-data-provider.service.ts

@@ -48,7 +48,7 @@ export class FtsoDataProviderService {
   constructor(manager: EntityManager, configService: ConfigService) {
     const required_history_sec = configService.get<number>("required_indexer_history_time_sec");
     this.indexer_top_timeout = configService.get<number>("indexer_top_timeout");
-    this.indexerClient = new IndexerClient(manager, required_history_sec);
+    this.indexerClient = new IndexerClient(manager, required_history_sec, new Logger(IndexerClient.name));
     this.rewardEpochManager = new RewardEpochManager(this.indexerClient);
     this.priceProviderClient = new Api({ baseURL: configService.get<string>("price_provider_url") });
     this.dataManager = new DataManager(this.indexerClient, this.rewardEpochManager, this.logger);

apps/ftso-reward-calculator/src/protocol-services/ftso/ftso-reward.service.ts

@@ -25,7 +25,7 @@ export class FtsoRewardingService extends BaseRewardingService {
     this.entityManager = manager;
     const required_history_sec = configService.get<number>("required_indexer_history_time_sec");
     this.indexer_top_timeout = configService.get<number>("indexer_top_timeout");
-    this.indexerClient = new IndexerClient(manager, required_history_sec);
+    this.indexerClient = new IndexerClient(manager, required_history_sec, new Logger(IndexerClient.name));
     this.rewardEpochManger = new RewardEpochManager(this.indexerClient);
     this.dataManager = new DataManager(this.indexerClient, this.rewardEpochManger, this.logger);
   }

libs/ftso-core/src/IndexerClient.ts

@@ -25,6 +25,8 @@ import {
   VoterRegistered,
   VoterRegistrationInfo,
 } from "./events";
+import { ILogger } from "./utils/ILogger";
+import { errorString } from "./utils/error";
 
 /**
  * Generic object for submission data and finalization data.
@@ -132,7 +134,11 @@ export enum BlockAssuranceResult {
  * the protocol data provider to function properly.
  */
 export class IndexerClient {
-  constructor(private readonly entityManager: EntityManager, public readonly requiredHistoryTimeSec: number) {}
+  constructor(
+    private readonly entityManager: EntityManager,
+    public readonly requiredHistoryTimeSec: number,
+    private readonly logger: ILogger
+  ) {}
 
   private readonly encoding = EncodingUtils.instance;
 
@@ -477,20 +483,26 @@ export class IndexerClient {
       };
     }
     const transactionsResults = await this.queryTransactions(CONTRACTS.Submission, functionName, startTime, endTime);
-    const submits: SubmissionData[] = transactionsResults.map(tx => {
-      const timestamp = tx.timestamp;
-      const votingEpochId = EPOCH_SETTINGS.votingEpochForTimeSec(timestamp);
-      const messages = decodePayloadMessageCalldata(tx);
-      return {
-        submitAddress: "0x" + tx.from_address,
-        relativeTimestamp: timestamp - EPOCH_SETTINGS.votingEpochStartSec(votingEpochId),
-        votingEpochIdFromTimestamp: votingEpochId,
-        transactionIndex: tx.transaction_index,
-        timestamp,
-        blockNumber: tx.block_number,
-        messages,
-      };
-    });
+
+    const submits: SubmissionData[] = [];
+    for (const tx of transactionsResults) {
+      try {
+        const timestamp = tx.timestamp;
+        const votingEpochId = EPOCH_SETTINGS.votingEpochForTimeSec(timestamp);
+        const messages = decodePayloadMessageCalldata(tx);
+        submits.push({
+          submitAddress: "0x" + tx.from_address,
+          relativeTimestamp: timestamp - EPOCH_SETTINGS.votingEpochStartSec(votingEpochId),
+          votingEpochIdFromTimestamp: votingEpochId,
+          transactionIndex: tx.transaction_index,
+          timestamp,
+          blockNumber: tx.block_number,
+          messages,
+        });
+      } catch (e) {
+        this.logger.warn(`Error processing submission transaction ${tx.hash}, will ignore: ${errorString(e)}`);
+      }
+    }
 
     return {
       status: ensureRange,

test/libs/integration/RewardEpochManager.test.ts

@@ -43,7 +43,7 @@ describe("RewardEpochManager", () => {
     const rewardEpochId = 1;
     await setUpRewardEpoch(rewardEpochId);
 
-    const epochManager = new RewardEpochManager(new IndexerClient(em, indexerHistorySec));
+    const epochManager = new RewardEpochManager(new IndexerClient(em, indexerHistorySec, console));
     const votingRound = epochSettings.expectedFirstVotingRoundForRewardEpoch(rewardEpochId);
     const rewardEpoch = await epochManager.getRewardEpoch(votingRound);