refactor(script): update payment calculation

Author: fassko

examples/developer-hub-javascript/fassetsReserveCollateral.ts

@@ -1,23 +1,18 @@
-import { ethers } from "hardhat";
-
-import {
-  IAssetManagerInstance,
-  IAssetManagerContract,
-} from "../../typechain-types";
+import { getFXRPAssetManagerAddress } from "../utils/fassets";
+import { IAssetManagerInstance } from "../../typechain-types";
+import { logEvents } from "../../scripts/utils/core";
 
 // 1. Define constants
 
-// AssetManager address on Flare Testnet Coston2 network
-const ASSET_MANAGER_ADDRESS = "0xDeD50DA9C3492Bee44560a4B35cFe0e778F41eC5";
 // Number of lots to reserve
 const LOTS_TO_MINT = 1;
-// XRP Ledger address
-const UNDERLYING_ADDRESS = "rSHYuiEvsYsKR8uUHhBTuGP5zjRcGt4nm";
-
 // Use zero address for executor since we're not using it
 const ZERO_ADDRESS = "0x0000000000000000000000000000000000000000";
 
-// 2. Function to find the best agent with enough free collateral lots
+// 2. Get the AssetManager artifact
+const AssetManager = artifacts.require("IAssetManager");
+
+// 3. Function to find the best agent with enough free collateral lots
 
 // Function from FAssets Bot repository
 // https://github.com/flare-foundation/fasset-bots/blob/main/packages/fasset-bots-core/src/commands/InfoBotCommands.ts#L83
@@ -69,105 +64,88 @@ async function findBestAgent(
   }
 }
 
-// 3. Function to parse the CollateralReserved event
-
-async function parseCollateralReservedEvent(transactionReceipt) {
+// 4. Function to parse the CollateralReserved event
+async function parseCollateralReservedEvent(
+  transactionReceipt: any,
+  decimals: number,
+) {
   console.log("\nParsing events...", transactionReceipt.rawLogs);
 
-  const assetManager = (await ethers.getContractAt(
-    "IAssetManager",
-    ASSET_MANAGER_ADDRESS,
-  )) as IAssetManagerContract;
-
-  for (const log of transactionReceipt.rawLogs) {
-    try {
-      const parsedLog = assetManager.interface.parseLog({
-        topics: log.topics,
-        data: log.data,
-      });
-
-      if (!parsedLog) continue;
-
-      const collateralReservedEvents = ["CollateralReserved"];
-      if (!collateralReservedEvents.includes(parsedLog.name)) continue;
-
-      console.log(`\nEvent: ${parsedLog.name}`);
-      console.log("Arguments:", parsedLog.args);
-      const collateralReservedEvent = parsedLog.args;
+  // 5. The logEvents function is included in the Flare starter kit
+  const collateralReservedEvents = logEvents(
+    transactionReceipt.rawLogs,
+    "CollateralReserved",
+    AssetManager.abi,
+  );
 
-      return collateralReservedEvent;
-    } catch (e) {
-      console.log("Error parsing event:", e);
-    }
-  }
+  return collateralReservedEvents[0].decoded;
 }
 
-// 4. Main function
-
 async function main() {
-  // Initialize the FAssets FXRP AssetManager contract
-  const AssetManager = artifacts.require("IAssetManager");
-  const assetManager: IAssetManagerInstance = await AssetManager.at(
-    ASSET_MANAGER_ADDRESS,
-  );
+  // 6. Get the AssetManager contract from the Flare Contract Registry
+  const assetManager: IAssetManagerInstance =
+    await getFXRPAssetManagerAddress();
 
-  // 5. Find the best agent with enough free collateral lots
+  // 7. Find the best agent with enough free collateral lots
   const agentVaultAddress = await findBestAgent(assetManager, LOTS_TO_MINT);
   if (!agentVaultAddress) {
     throw new Error("No suitable agent found with enough free collateral lots");
   }
   console.log(agentVaultAddress);
 
-  // 6. Get the agent info
+  // 8. Get the agent info
   const agentInfo = await assetManager.getAgentInfo(agentVaultAddress);
   console.log("Agent info:", agentInfo);
 
-  // 7. Get the collateral reservation fee according to the number of lots to reserve
+  // 9. Get the collateral reservation fee according to the number of lots to reserve
   // https://dev.flare.network/fassets/minting/#collateral-reservation-fee
   const collateralReservationFee =
     await assetManager.collateralReservationFee(LOTS_TO_MINT);
   console.log(
     "Collateral reservation fee:",
     collateralReservationFee.toString(),
   );
+  console.log("agentVaultAddress", agentVaultAddress);
+  console.log("LOTS_TO_MINT", LOTS_TO_MINT);
+  console.log("agentInfo.feeBIPS", agentInfo.feeBIPS);
+  console.log("ZERO_ADDRESS", ZERO_ADDRESS);
 
-  const IAssetManager = artifacts.require("IAssetManager");
-  const iAssetManager: IAssetManagerInstance = await IAssetManager.at(
-    ASSET_MANAGER_ADDRESS,
-  );
+  console.log("collateralReservationFee", collateralReservationFee);
 
-  // 8. Reserve collateral
+  // 10. Reserve collateral
   // https://dev.flare.network/fassets/reference/IAssetManager#reservecollateral
-  const tx = await iAssetManager.reserveCollateral(
+  const tx = await assetManager.reserveCollateral(
     agentVaultAddress,
     LOTS_TO_MINT,
     agentInfo.feeBIPS,
     // Not using the executor
     ZERO_ADDRESS,
-    [UNDERLYING_ADDRESS],
     // Sending the collateral reservation fee as native tokens
     { value: collateralReservationFee },
   );
 
   console.log("Collateral reservation successful:", tx);
 
-  // 9. Get the asset decimals
+  // 11. Get the asset decimals
   const decimals = await assetManager.assetMintingDecimals();
 
-  // 10. Parse the CollateralReserved event
+  // 12. Parse the CollateralReserved event
   const collateralReservedEvent = await parseCollateralReservedEvent(
     tx.receipt,
+    decimals,
   );
 
+  // 13. Get the collateral reservation info
   const collateralReservationInfo =
     await assetManager.collateralReservationInfo(
       collateralReservedEvent.collateralReservationId,
     );
   console.log("Collateral reservation info:", collateralReservationInfo);
 
-  // 11. Calculate the total amount of XRP to pay
-  const totalUBA =
-    collateralReservedEvent.valueUBA + collateralReservedEvent.feeUBA;
+  // 14. Calculate the total XRP value required for payment
+  const valueUBA = BigInt(collateralReservedEvent.valueUBA.toString());
+  const feeUBA = BigInt(collateralReservedEvent.feeUBA.toString());
+  const totalUBA = valueUBA + feeUBA;
   const totalXRP = Number(totalUBA) / 10 ** decimals;
   console.log(`You need to pay ${totalXRP} XRP`);
 }