test fix - issue with deep copy of closures in async cache

Author: Iztok

packages/fasset-bots-common/src/utils/AsyncCache.ts

@@ -6,11 +6,14 @@ export interface CacheEntry<R> {
 }
 
 export class AsyncCache<ARGS extends CachedMethodArg[], R> {
+    static deepCopyWithObjectCreate = true;
+
     private cache: Map<string, CacheEntry<unknown>>;
 
     constructor(
-        public readonly maxAgeMS: number,
-        public readonly computeValue: (...args: ARGS) => Promise<R>,
+        public maxAgeMS: number,
+        public computeValue: (...args: ARGS) => Promise<R>,
+        public thisArg?: unknown,
     ) {
         this.cache = new Map();
     }
@@ -21,7 +24,7 @@ export class AsyncCache<ARGS extends CachedMethodArg[], R> {
         if (entry != null && entry.expiresAt > Date.now()) {
             return entry.value as R;
         } else {
-            const value = await this.computeValue(...args);
+            const value = await this.computeValue.apply(this.thisArg, args);
             const expiresAt = Date.now() + this.maxAgeMS;
             this.cache.set(key, { value, expiresAt });
             return value;

packages/fasset-bots-common/test/unit/utils/AsyncCache.test.ts

@@ -91,4 +91,17 @@ describe('AsyncCache', () => {
         expect(v1b).to.equal(1);
         expect(compute.callCount).to.equal(2);
     });
+
+    it('supports thisArg for computeValue', async () => {
+        const context = {
+            factor: 10,
+            async compute(n: number): Promise<number> {
+                return n * this.factor;
+            }
+        };
+        const cache = new AsyncCache<[number], number>(1000, context.compute, context);
+
+        const result = await cache.getOrCompute(5);
+        expect(result).to.equal(50);
+    });
 });

packages/fasset-bots-core/src/actors/AgentBotMinting.ts

@@ -179,7 +179,8 @@ export class AgentBotMinting {
 
     // for minting checks, 1 refresh of finalized block per minute is enough
     lastFinalizedUnderlyingBlockCached = new AsyncCache(1 * MINUTES_MS,
-        async () => await lastFinalizedUnderlyingBlock(this.context.blockchainIndexer));
+        async function (this: AgentBotMinting) { return await lastFinalizedUnderlyingBlock(this.context.blockchainIndexer); },
+        this);
 
     /**
      * Check if time for payment expired on underlying. If if did not expire, then it does nothing.

packages/fasset-bots-core/test-hardhat/integration/agentBot.ts

@@ -81,6 +81,7 @@ describe("Agent bot tests", () => {
         await testWhitelistAndSetWorkAddress(context.agentOwnerRegistry, ownerManagementAddress, ownerManagementPrivateKey, ownerAddress);
         //
         agentBot = await createTestAgentBotAndMakeAvailable(context, governance, orm, ownerManagementAddress, undefined, false);
+        agentBot.minting.lastFinalizedUnderlyingBlockCached.maxAgeMS = 0; // disable caching for tests
         minter = await createTestMinter(context, minterAddress, chain);
         redeemer = await createTestRedeemer(context, redeemerAddress);
         await proveAndUpdateUnderlyingBlock(context.attestationProvider, context.assetManager, ownerAddress);