fix: minor service healthcheck fixes

Author: kuco23

packages/fasset-bots-cli/src/run/run-agent.ts

@@ -1,7 +1,7 @@
 import "dotenv/config";
 import "source-map-support/register";
 
-import { AgentBotRunner, PricePublisherService, startActivityTimestampUpdater, startHealthcheckMonitor, stopActivityTimestampUpdater, TimeKeeperService, TimekeeperTimingConfig } from "@flarenetwork/fasset-bots-core";
+import { AgentBotRunner, PricePublisherService, startActivityTimestampUpdater, startHealthcheckMonitor, stopActivityTimestampUpdater, stopHealthcheckMonitor, TimeKeeperService, TimekeeperTimingConfig } from "@flarenetwork/fasset-bots-core";
 import { closeBotConfig, createBotConfig, loadAgentConfigFile, Secrets } from "@flarenetwork/fasset-bots-core/config";
 import { assertCmd, assertNotNullCmd, authenticatedHttpProvider, CommandLineError, formatFixed, initWeb3, isNotNull, logger, sendWeb3Transaction, toBN, toBNExp, web3 } from "@flarenetwork/fasset-bots-core/utils";
 import BN from "bn.js";
@@ -124,6 +124,7 @@ program.action(async () => {
                 await pricePublisherService.stop();
             }
             stopActivityTimestampUpdater();
+            stopHealthcheckMonitor();
             await timekeeperService.stopAll();
             await closeBotConfig(botConfig);
         }

packages/fasset-bots-core/src/actors/service-health-checker.ts

@@ -76,17 +76,18 @@ async function serviceHealthcheck(
         const dalHealth = await checkDalHealth(c.flareDataConnector)
         const walletHealth = await checkUnderlyingWalletHealth(c.wallet)
         if (rpcHealth != null) {
-            errors.push(['native rpc', rpcHealth])
+            errors.push(['Native RPC', rpcHealth])
         } else if (indexerHealth != null) {
             errors.push(['FDC verifier', indexerHealth])
         } else if (dalHealth != null) {
             errors.push(['DAL', dalHealth])
         } else if (walletHealth != null) {
-            errors.push(['underlying rpc', walletHealth])
+            errors.push(['Underlying RPC', walletHealth])
         }
     }
     for (const [service, reason] of errors) {
-        notifier.serviceUnhealthy(service, reason)
+        logger.error(`Service ${service} is unhealthy: ${reason}`)
+        await notifier.serviceUnhealthy(service, reason)
     }
 }