Bugfixes (pointer to range variable)

Author: mboben

indexer/xchain/in_updater.go

@@ -47,8 +47,8 @@ func (iu *xChainInputUpdater) updateFromDB(
 		return nil, err
 	}
 	baseOuts := shared.NewOutputMap()
-	for _, out := range outs {
-		baseOuts.Add(shared.NewIdIndexKey(out.TxID, out.Index()), &out.TxOutput)
+	for i, out := range outs {
+		baseOuts.Add(shared.NewIdIndexKey(out.TxID, out.Index()), &outs[i].TxOutput)
 	}
 	return inputs.UpdateWithOutputs(baseOuts), nil
 }

services/api/pchain.go

@@ -98,9 +98,8 @@ func newApiPChainTxListItem(tx *database.PChainTxData) ApiPChainTxListItem {
 
 func NewApiPChainTxList(txs []database.PChainTxData) []ApiPChainTxListItem {
 	result := make([]ApiPChainTxListItem, len(txs))
-	for i, tx := range txs {
-		result[i] = newApiPChainTxListItem(&tx)
+	for i := range txs {
+		result[i] = newApiPChainTxListItem(&txs[i])
 	}
-
 	return result
 }

utils/structures.go

@@ -19,15 +19,6 @@ func ArrayToMap[T, K comparable](ts []T, kf func(T) K) map[K]T {
 	return result
 }
 
-// Create a map from array with kf providing keys, values are pointers to array elements
-func ArrayToPtrMap[T, K comparable](ts []T, kf func(T) K) map[K]*T {
-	result := make(map[K]*T)
-	for _, t := range ts {
-		result[kf(t)] = &t
-	}
-	return result
-}
-
 func Keys[K comparable, V any](m map[K]V) []K {
 	keys := make([]K, 0, len(m))
 	for k := range m {