feat: panic on missing signing policy

Author: GrePod

client/finalizer/finalizer_client.go

@@ -2,7 +2,6 @@ package finalizer
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	clientContext "github.com/flare-foundation/flare-system-client/client/context"
@@ -218,10 +217,10 @@ func (c *client) messagesChannelListener(ctx context.Context) error {
 			oldestSP := c.signingPolicyStorage.OldestStored()
 			if oldestSP != nil && protocolMessage.VotingRoundID < oldestSP.StartVotingRoundID {
 				// This is a submission for an old voting round, skip it
-				logger.Debugf("Ignoring message for voting round %d, protocolID  %d - before policy startVotingRoundID", protocolMessage.VotingRoundID, protocolMessage.ProtocolID)
+				logger.Warnf("Ignoring message for voting round %d, protocolID  %d - before policy startVotingRoundID", protocolMessage.VotingRoundID, protocolMessage.ProtocolID)
 				continue
 			}
-			return fmt.Errorf("no signing policy found for voting round %d", protocolMessage.VotingRoundID) // this stops the whole fsp client
+			logger.Panicf("messagesChannelListener: no signing policy found for voting round %d. Storage is empty: %v", protocolMessage.VotingRoundID, c.signingPolicyStorage.OldestStored() == nil) // this stops the whole fsp client, it only happens if there is no signing policy in the storage.
 		}
 		finalizationReady, err := c.finalizationStorage.AddMessage(&protocolMessage, sp, threshold)
 

client/finalizer/submission_processor.go

@@ -2,7 +2,6 @@ package finalizer
 
 import (
 	"encoding/hex"
-	"fmt"
 
 	"github.com/flare-foundation/go-flare-common/pkg/database"
 	"github.com/flare-foundation/go-flare-common/pkg/logger"
@@ -61,18 +60,18 @@ func (c *client) ProcessSubmissionData(payloads []*submitSignaturesPayload) erro
 
 		// Skip if voting round is in the future
 		if !c.checkVotingRoundTime(payloadItem.votingRoundID) {
-			logger.Debugf("Ignoring submitted signature for voting round %d, protocolID  %d - round not started yet", payloadItem.votingRoundID, payloadItem.protocolID)
+			logger.Debugf("ProcessSubmissionData: Ignoring submitted signature for voting round %d, protocolID  %d - round not started yet", payloadItem.votingRoundID, payloadItem.protocolID)
 			continue
 		}
 		sp, threshold := c.signingPolicyData(payloadItem.votingRoundID)
 		if sp == nil {
 			oldestSP := c.signingPolicyStorage.OldestStored()
 			if oldestSP != nil && payloadItem.votingRoundID < oldestSP.StartVotingRoundID {
 				// This is a submission for an old voting round, skip it
-				logger.Debugf("Ignoring submitted signature for voting round %d, protocolID  %d - before policy startVotingRoundID", payloadItem.votingRoundID, payloadItem.protocolID)
+				logger.Warnf("ProcessSubmissionData: Ignoring submitted signature for voting round %d, protocolID  %d - before policy startVotingRoundID", payloadItem.votingRoundID, payloadItem.protocolID)
 				continue
 			}
-			return fmt.Errorf("no signing policy found for voting round %d", payloadItem.votingRoundID) // this stops the whole fsp client
+			logger.Panicf("ProcessSubmissionData: no signing policy found for voting round %d. Storage is empty: %v", payloadItem.votingRoundID, c.signingPolicyStorage.OldestStored() == nil) // this stops the whole fsp client, it only happens if there is no signing policy in the storage.
 		}
 		finalizationReady, err := c.finalizationStorage.addPayload(payloadItem, sp, threshold)
 		if err != nil {