feat: always assign network to message

Author: janezicmatej

observer/message.py

@@ -3,7 +3,7 @@
 import io
 from typing import Self
 
-from attrs import define, frozen
+from attrs import define
 from py_flare_common.fsp.epoch.epoch import VotingEpoch
 
 from configuration.config import ChainId, Protocol, ProtocolId
@@ -17,12 +17,12 @@ class MessageLevel(enum.Enum):
     CRITICAL = 50
 
 
-@frozen
+@define
 class Message:
     level: MessageLevel
     message: str
+    network: int
 
-    network: int | None = None
     round: VotingEpoch | None = None
     protocol: ProtocolId | None = None
 

observer/notification.py

@@ -95,14 +95,12 @@ def notify_discord_embed(config: NotificationDiscord, message: Message) -> None:
             "text": "Flare Network",
             "icon_url": get_icon_url(ChainId.FLARE),
         },
-    }
-
-    if message.network is not None:
-        embed["thumbnail"] = {
+        "thumbnail": {
             "url": get_icon_url(message.network),
             "height": 32,
             "width": 32,
-        }
+        },
+    }
 
     for u in config.webhook_url:
         notify(

observer/observer.py

@@ -299,6 +299,8 @@ def log_message(config: Configuration, message: Message):
     LOGGER.log(message.level.value, message.message)
 
     n = config.notification
+    # TODO:(@janezicmatej) this should be done eariler in the message lifecycle
+    message.network = config.chain_id
 
     notify_discord(n.discord, message)
     notify_discord_embed(n.discord_embed, message)