feat: update address validity response statuses to use INVALID_ADDRESS_VERSION

Author: andraz maier

src/verification/address-validity/address-validity-btc.ts

@@ -284,7 +284,7 @@ export function verifyAddressBTC(
           // wrong prefix
         } else if (!(decodedAddress[0] == 111 || decodedAddress[0] == 196))
           return {
-            status: AttestationResponseStatus.INVALID_ADDRESS_PREFIX,
+            status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
             response: INVALID_ADDRESS_RESPONSE,
           };
         else {
@@ -313,7 +313,7 @@ export function verifyAddressBTC(
         // invalid address / unsupported version
         else
           return {
-            status: AttestationResponseStatus.UNSUPPORTED_ADDRESS_VERSION,
+            status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
             response: INVALID_ADDRESS_RESPONSE,
           };
       }
@@ -363,7 +363,7 @@ export function verifyAddressBTC(
           // wrong prefix
         } else if (!(decodedAddress[0] == 0 || decodedAddress[0] == 5))
           return {
-            status: AttestationResponseStatus.INVALID_ADDRESS_PREFIX,
+            status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
             response: INVALID_ADDRESS_RESPONSE,
           };
         else {
@@ -392,7 +392,7 @@ export function verifyAddressBTC(
         // invalid address / unsupported version
         else
           return {
-            status: AttestationResponseStatus.UNSUPPORTED_ADDRESS_VERSION,
+            status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
             response: INVALID_ADDRESS_RESPONSE,
           };
       }

src/verification/address-validity/address-validity-doge.ts

@@ -38,8 +38,7 @@ export function verifyAddressDOGE(
   }
 
   //length is base58
-  const shortLen = 25 > address.length || address.length > 34;
-  if (shortLen)
+  if (25 > address.length || address.length > 34)
     return {
       status: AttestationResponseStatus.INVALID_ADDRESS_LENGTH,
       response: INVALID_ADDRESS_RESPONSE,
@@ -57,7 +56,7 @@ export function verifyAddressDOGE(
   const prefix = validPrefix.includes(address[0]);
   if (!prefix)
     return {
-      status: AttestationResponseStatus.INVALID_ADDRESS_PREFIX,
+      status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
       response: INVALID_ADDRESS_RESPONSE,
     };
 
@@ -81,7 +80,7 @@ export function verifyAddressDOGE(
   //prefix in hex
   if (!validPrefixDecodedDec.includes(decodedAddress[0]))
     return {
-      status: AttestationResponseStatus.INVALID_ADDRESS_PREFIX,
+      status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
       response: INVALID_ADDRESS_RESPONSE,
     };
   else {

src/verification/address-validity/address-validity-xrp.ts

@@ -15,7 +15,7 @@ import {
 const R_B58_DICT = 'rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz';
 const base58 = base(R_B58_DICT);
 const classicAddressRegex =
-  /r[rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz]{24,34}/;
+  /[rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz]{24,34}/;
 const invalidCharacters =
   /[^rpshnaf39wBUDNEGHJKLM4PQRST7VWXYZ2bcdeCg65jkm8oFqi1tuvAxyz]/;
 
@@ -48,15 +48,15 @@ export function verifyAddressXRP(
 
   const checksum = base58Checksum(decodedAddress);
 
-  if (!checksum)
+  if (decodedAddress[0] != 0)
     return {
-      status: AttestationResponseStatus.INVALID_ADDRESS_CHECKSUM,
+      status: AttestationResponseStatus.INVALID_ADDRESS_VERSION,
       response: INVALID_ADDRESS_RESPONSE,
     };
 
-  if (decodedAddress[0] != 0)
+  if (!checksum)
     return {
-      status: AttestationResponseStatus.INVALID_ADDRESS_PREFIX,
+      status: AttestationResponseStatus.INVALID_ADDRESS_CHECKSUM,
       response: INVALID_ADDRESS_RESPONSE,
     };
 

src/verification/response-status.ts

@@ -38,12 +38,11 @@ export enum AttestationResponseStatus {
   REFERENCED_TRANSACTION_EXISTS = 'INVALID: REFERENCED TRANSACTION EXISTS',
   MORE_THAN_ONE_OUTPUT = 'INVALID: MORE_THAN_ONE_OUTPUT',
   INVALID_ADDRESS_CHARACTER = 'INVALID: INVALID ADDRESS CHARACTER',
+  INVALID_ADDRESS_VERSION = 'INVALID: INVALID ADDRESS VERSION',
   INVALID_ADDRESS_LENGTH = 'INVALID: INVALID ADDRESS LENGTH',
   INVALID_DECODED_ADDRESS_LENGTH = 'INVALID: INVALID DECODED ADDRESS LENGTH',
   INVALID_ADDRESS_CHECKSUM = 'INVALID: INVALID ADDRESS CHECKSUM',
-  UNSUPPORTED_ADDRESS_VERSION = 'INVALID: UNSUPPORTED ADDRESS VERSION',
   INVALID_ADDRESS_TYPE = 'INVALID: INVALID ADDRESS TYPE',
-  INVALID_ADDRESS_PREFIX = 'INVALID: INVALID_ADDRESS_PREFIX',
 
   // TEMPORARY STATUS
   // Temporary status during checks