Refactor: upgrade linter and correct linter errors

Author: andraz maier

eslint.config.mjs

@@ -2,7 +2,6 @@
 
 import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
-import * as importPlugin from 'eslint-plugin-import';
 
 export default tseslint.config(
   eslint.configs.recommended,
@@ -16,15 +15,8 @@ export default tseslint.config(
         tsconfigRootDir: import.meta.dirname,
       },
     },
-    // extends: [
-    //   flatConfigs.recommended, flatConfigs.typescript
-    // ],
-    plugins: {
-      import: importPlugin
-    },
-  // },
-  // {
-    // add aditional rules here
+    // import plugins for rules
+    // plugins: { import: importPlugin },
     rules: {
       // Disables the rule that prefers the namespace keyword over the module keyword for declaring TypeScript namespaces.
       '@typescript-eslint/prefer-namespace-keyword': 'off',
@@ -46,8 +38,6 @@ export default tseslint.config(
       'guard-for-in': 'warn',
       // Errors when a case in a switch statement falls through to the next case without a break statement or other termination.
       'no-fallthrough': 'error',
-      // Only allow relative path imports (e.g., import { foo } from './foo';). 
-      'import/no-absolute-path': 'error',
     },
   },
   // Override rules for specific files

package.json

@@ -11,7 +11,6 @@
   ],
   "scripts": {
     "build": "nest build",
-    "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"",
     "start": "nest start",
     "start:dev": "nest start --watch",
     "start:debug": "nest start --debug --watch",

src/external-libs/AttestationDefinitionStore.ts

@@ -164,16 +164,16 @@ export class AttestationDefinitionStore {
     ) {
       throw new Error(`Invalid request ABI`);
     }
-    const requestBodyAbi: unknown = definition.requestAbi.components.find(
+    const requestBodyAbi = definition.requestAbi.components.find(
       (item: ABIFragment) => item.name == 'requestBody',
-    );
+    ) as ABIFragment;
     if (!requestBodyAbi) {
       throw new Error(
         `Invalid request ABI for attestation type id: '${request.attestationType}'. No 'requestBody'.`,
       );
     }
     const abiEncodeBody = this.coder.encode(
-      [requestBodyAbi],
+      [requestBodyAbi as unknown as ParamType],
       [request.requestBody],
     );
     return ethers.concat([abiEncodePrefix, abiEncodeBody]);
@@ -217,24 +217,23 @@ export class AttestationDefinitionStore {
     ) {
       throw new Error(`Invalid request ABI`);
     }
-    const requestBodyAbi: unknown = definition.requestAbi?.components.find(
+    const requestBodyAbi = definition.requestAbi?.components.find(
       (item: ABIFragment) => item.name == 'requestBody',
-    );
+    ) as ABIFragment;
     if (!requestBodyAbi) {
       throw new Error(
         `Invalid request ABI for attestation type id: '${prefix.attestationType}'. No 'requestBody'.`,
       );
     }
-
     const parsed: unknown = this.coder.decode(
-      [requestBodyAbi],
+      [requestBodyAbi as unknown as ParamType],
       '0x' + bytes.slice(2 + 3 * 64),
     )[0];
     return serializeBigInts({
       attestationType: prefix.attestationType,
       sourceId: prefix.sourceId,
       messageIntegrityCode: prefix.messageIntegrityCode,
-      requestBody: remapABIParsedToObjects(parsed, requestBodyAbi) as unknown,
+      requestBody: remapABIParsedToObjects(parsed, requestBodyAbi),
     }) as AR;
   }
 

src/external-libs/utils.ts

@@ -150,21 +150,21 @@ export function decodeAttestationName(encoded: string) {
  * @returns
  */
 export function remapABIParsedToObjects(
-  decoded: any,
+  decoded: unknown,
   abi: ABIFragment,
   ignoreArray = false,
-): any {
+): unknown {
   if (abi.type == 'tuple' || (abi.type == 'tuple[]' && ignoreArray)) {
-    const result: any = {};
+    const result = {};
     for (const [index, item] of abi.components.entries()) {
       const key = item.name;
       result[key] = remapABIParsedToObjects(decoded[index], item);
     }
     return result;
   }
   if (abi.type == 'tuple[]') {
-    const result: any = [];
-    for (const item of decoded) {
+    const result = [];
+    for (const item of decoded as unknown[]) {
       result.push(remapABIParsedToObjects(item, abi, true));
     }
     return result;
@@ -181,8 +181,8 @@ export function remapABIParsedToObjects(
   // we assume here we have `type[]` where `type` is one of simple types.
   const match = abi.type.match(/^(.+)\[\]$/);
   if (match && isSupportedBasicSolidityType(match[1])) {
-    const result: any = [];
-    for (const item of decoded) {
+    const result = [];
+    for (const item of decoded as unknown[]) {
       result.push(item);
     }
     return result;

src/services/common/verifier-base.service.ts

@@ -43,7 +43,10 @@ interface IVerificationServiceWithIndexerConfig
     | typeof XrpIndexerQueryManager;
 }
 
-export type ITypeSpecificVerificationServiceConfig = Omit<IVerificationServiceWithIndexerConfig, 'attestationName'>;
+export type ITypeSpecificVerificationServiceConfig = Omit<
+  IVerificationServiceWithIndexerConfig,
+  'attestationName'
+>;
 
 export abstract class BaseVerifierService<
   Req extends AttestationTypeBase_Request,

src/utils/api-models/ApiResponse.ts

@@ -76,7 +76,10 @@ export async function handleApiResponse<T>(
     return new ApiResponseWrapper<T>(resp);
   } catch (reason) {
     if (sanitize) {
-      const message = reason instanceof Error ? reason.message : 'Error while processing request';
+      const message =
+        reason instanceof Error
+          ? reason.message
+          : 'Error while processing request';
       return new ApiResponseWrapper<T>(
         undefined,
         ApiResStatusEnum.ERROR,