only payment tx may have payment reference

Author: ryanc-flare

internal/xrp/xrp.go

@@ -17,8 +17,11 @@ import (
 	"github.com/pkg/errors"
 )
 
-const XRPCurrency = "XRP"
-const XRPTimeToUTD = uint64(946684800)
+const (
+	XRPCurrency  = "XRP"
+	XRPTimeToUTD = uint64(946684800)
+	paymentType  = "Payment"
+)
 
 type Config struct {
 	Url string `toml:"url"`
@@ -250,8 +253,12 @@ func (c XRPClient) GetBlockResult(ctx context.Context, blockNum uint64,
 			Response:    string(respStruct.Result.Ledger.Transactions[i]),
 		}
 
-		transactions[i].PaymentReference = paymentReference(tx)
-		transactions[i].IsNativePayment = isNativePayment(tx)
+		// case-insensitive check for transaction type
+		if strings.EqualFold(tx.TransactionType, paymentType) {
+			transactions[i].PaymentReference = paymentReference(tx)
+			transactions[i].IsNativePayment = isNativePayment(tx)
+		}
+
 		transactions[i].SourceAddressesRoot, err = sourceAddressesRoot(tx)
 		if err != nil {
 			return nil, err
@@ -276,23 +283,18 @@ func paymentReference(tx XRPTransaction) string {
 }
 
 func isNativePayment(tx XRPTransaction) bool {
-	if tx.TransactionType == "Payment" {
-		var amountStr string
-		err := json.Unmarshal(tx.Amount, &amountStr)
+	var amountStr string
+	err := json.Unmarshal(tx.Amount, &amountStr)
+	if err == nil {
+		_, err = strconv.Atoi(amountStr)
 		if err == nil {
-			_, err = strconv.Atoi(amountStr)
-			if err == nil {
-				return true
-			}
-		}
-		var amountStruct XRPAmount
-		err = json.Unmarshal(tx.Amount, &amountStruct)
-		if err == nil && amountStruct.Currency == XRPCurrency {
 			return true
 		}
 	}
+	var amountStruct XRPAmount
+	err = json.Unmarshal(tx.Amount, &amountStruct)
 
-	return false
+	return err == nil && amountStruct.Currency == XRPCurrency
 }
 
 func sourceAddressesRoot(tx XRPTransaction) (string, error) {