feat: updated the hash process when calculating first memo data hash

Author: LukaAvbreht

CLAUDE.md

@@ -0,0 +1,90 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+XRP Ledger blockchain indexer built in Go. Collects blocks and transactions from XRP and stores them in PostgreSQL. Built on the `verifier-indexer-framework` which provides the indexing loop, database management, and configuration loading — this repo implements the XRP-specific `BlockchainClient` interface.
+
+## Build & Run Commands
+
+```bash
+# Build
+go build ./cmd/indexer
+
+# Run locally (two terminals):
+# Terminal 1: start PostgreSQL
+cd tests/ && docker compose up postgresdb
+# Terminal 2: run the indexer
+go run ./cmd/indexer --config tests/config_test.toml
+
+# Test (requires running xrpld — see below)
+go test ./...
+
+# Run a single test
+go test ./internal/xrp/ -run TestFirstMemoDataHash
+# Run a single subtest
+go test ./internal/xrp/ -run TestXrpTestSuite/TestGetBlockResult
+
+# Lint (uses golangci-lint v2+)
+golangci-lint run --timeout 5m0s
+
+# Format
+go fmt ./...
+```
+
+## Test Infrastructure
+
+There are two types of tests:
+- **Unit tests** (e.g., `TestFirstMemoDataHash` in `memo_test.go`): Run without external dependencies, use `package xrp` to test unexported functions.
+- **Integration tests** (e.g., `XrpTestSuite`): Require a running xrpld standalone node. The test setup creates wallets, funds accounts, and submits transactions against the local xrpld.
+
+```bash
+# Start xrpld standalone node (from repo root)
+docker compose up -d
+# Tests connect to xrpld RPC at http://localhost:5005
+# Override with XRP_RPC_URL env var
+```
+
+Test suites use `testify/suite`. Integration tests are in `xrp_test.go` (package `xrp_test`), unit tests are in `memo_test.go` (package `xrp`).
+
+## Architecture
+
+**Entry point**: `cmd/indexer/main.go` — minimal bootstrap that calls the framework's `Run()` with XRP-specific types. The framework handles config loading, CLI arg parsing (`--config`, default `config.toml`), logger setup, database init, and the indexing loop.
+
+**Core implementation**: `internal/xrp/` (only 3 source files):
+- `xrp.go` — `xrpClient` implementing `indexer.BlockchainClient` interface (GetLatestBlockInfo, GetBlockTimestamp, GetBlockResult, GetServerInfo). Handles JSON-RPC communication with XRP nodes, transaction parsing, and field extraction.
+- `entities.go` — GORM models for `Block` and `Transaction` tables. Implements `database.Deletable` for history cleanup.
+
+**Transaction field extraction** (in `GetBlockResult`):
+- `PaymentReference`: From first memo's MemoData if exactly 64 hex chars (payment transactions only)
+- `FirstMemoDataHash`: Keccak256 hash of hex-decoded first memo MemoData
+- `IsNativePayment`: True if Amount is a digit string (drops) or has `currency: "XRP"`
+- `SourceAddressesRoot`: Merkle root of Keccak256-hashed accounts with decreased balance
+- `SourceAddress`, `Sequence`, `TicketSequence`, `DestinationTag`: Passed through from XRP transaction JSON
+
+**Key domain details**:
+- XRP timestamps use a custom epoch offset: `XRPTimeToUTD = 946684800` (seconds from Unix epoch to 2000-01-01)
+- XRP MemoData is hex-encoded — decode before hashing
+- Only `validated: true` ledgers are processed
+- The XRPL testnet is periodically reset; old blocks become unavailable
+
+## Configuration
+
+TOML-based config (see `config.example.toml`). The framework loads `config.toml` by default, overridable with `--config` flag or `CONFIG_FILE` env var. The `[blockchain].url` field can be overridden with the `XRP_URL` env var.
+
+Key `[indexer]` settings: `start_block_number` and `end_block_number` control the block range. With `history_drop` enabled (seconds), `start_block_number` is ignored and the indexer starts from the history window.
+
+## Local Framework Development
+
+To develop against a local fork of `verifier-indexer-framework`, add a `replace` directive to `go.mod` (outside the `require` block):
+
+```
+replace github.com/flare-foundation/verifier-indexer-framework => ../verifier-indexer-framework
+```
+
+Keep the original `require` line with version intact. Remove the `replace` before committing.
+
+## Linting
+
+Strict `golangci-lint` config in `.golangci.yml` with ~28 linters enabled including `exhaustive` (switch completeness), `nolintlint` (requires specific linter in nolint directives), and `bodyclose`.

internal/xrp/memo_test.go

@@ -0,0 +1,49 @@
+package xrp
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestFirstMemoDataHash(t *testing.T) {
+	tests := []struct {
+		name     string
+		memoData string
+		expected string
+	}{
+		{
+			name:     "long memo data",
+			memoData: "5468697320746F6B656E2064726F70206973206120726573756C74206F6620796F75722041534320686F6C64696E67732070726F706F7274696F6E61746520746F20746F74616C20737570706C792C2063616C63756C617465642061732070726F6365656473206F6620343525206F6620616E6E75616C2031322C3030302C3030302041534320737570706C7920696E63726561736520646973747269627574656420746F20616C6C2041534320686F6C646572732077686572652044726F70733E46656573206F6E20616E20686F75726C792C206461696C792C207765656B6C792C206F72206D6F6E74686C792062617369732E20466F72206D6F726520696E666F726D6174696F6E2076697369742068747470733A2F2F7777772E617363656E73696F6E696E6465782E636F6D2F",
+			expected: "fe42159c2a27cf1451f890cec1aa0a07c8465da151794ec6a5a1294a261655d3",
+		},
+		{
+			name:     "short memo data",
+			memoData: "3639303835373338",
+			expected: "e8a4c3409f0f9db91fb53de91eb47e02e58f8f1062b7f1930a4defbf6d66e017",
+		},
+		{
+			name:     "binary-like memo data",
+			memoData: "46425052664100020000000000000000000000000000000000000000004D5760",
+			expected: "7513e735152cafd288c9247151d760f1ac038d318d6edadbe12c8cd0025739a6",
+		},
+		{
+			name:     "no memos",
+			memoData: "",
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var tx xrpTransaction
+			if tt.memoData != "" {
+				tx.Memos = []map[string]map[string]string{
+					{"Memo": {"MemoData": tt.memoData}},
+				}
+			}
+			result := firstMemoDataHash(tx)
+			require.Equal(t, tt.expected, result)
+		})
+	}
+}

internal/xrp/xrp.go

@@ -3,6 +3,7 @@ package xrp
 import (
 	"bytes"
 	"context"
+	"encoding/hex"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -303,7 +304,11 @@ func firstMemoDataHash(tx xrpTransaction) string {
 	if len(tx.Memos) > 0 {
 		if memo, ok := tx.Memos[0]["Memo"]; ok {
 			if memoData, ok := memo["MemoData"]; ok && memoData != "" {
-				hash := crypto.Keccak256Hash([]byte(memoData))
+				decoded, err := hex.DecodeString(memoData)
+				if err != nil {
+					return ""
+				}
+				hash := crypto.Keccak256Hash(decoded)
 				return strings.ToLower(hash.Hex()[2:])
 			}
 		}

tests/config_test.toml

@@ -4,17 +4,23 @@ password = "password"
 db_name = "flare_xrp_indexer"
 port = 5432
 drop_table_at_start = false
-history_drop = 3600
+history_drop = 13600
 history_drop_frequency = 600
 
 [indexer]
 confirmations = 1
 max_block_range = 100
-max_concurrency = 10
-start_block_number = 700000
+max_concurrency = 1
+start_block_number = 100000000
+# start_block_number = 10172243
+# end_block_number = 10172442
 
 [blockchain]
-url = "https://s.altnet.rippletest.net:51234"
+url = "https://s1.ripple.com:51234"
+# url = "https://xrplcluster.com"
+# Testnet
+# url = "https://s.altnet.rippletest.net:51234"
+# url = "https://testnet.xrpl-labs.com"
 
 [timeout]
 request_timeout_millis = 3000