release: Reopen certificate store only when installing certificate.

Author: Aetopia

src/Flarial.Launcher.Installer.csproj

@@ -19,7 +19,7 @@
 
   <PropertyGroup>
     <ApplicationIcon>Resources/app.ico</ApplicationIcon>
-    <ApplicationManifest>Resources/app.manifest</ApplicationManifest>
+   <ApplicationManifest>Resources/app.manifest</ApplicationManifest>
   </PropertyGroup>
 
   <ItemGroup>
@@ -35,7 +35,7 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <AssemblyVersion>1.1.0.0</AssemblyVersion>
+    <AssemblyVersion>1.1.1.0</AssemblyVersion>
     <AssemblyTitle>Flarial Launcher Installer</AssemblyTitle>
 
     <Company>Flarial</Company>

src/InstallerService.cs

@@ -24,24 +24,36 @@ static class InstallerService
     const string LauncherCertificateUri = "https://cdn.flarial.xyz/launcher/Flarial.Launcher.cer";
     const string LauncherCertificateThumbprint = "080862035B63C6B01A1F7F5E2A286939808F502ADCA100BDCB6F805FB0DD4171";
 
-    internal static Task InstallCertificateAsync() => Task.Run(static async () =>
+    static bool IsCertificateInstalled
     {
-        using X509Store certificateStore = new(StoreName.TrustedPeople, StoreLocation.LocalMachine);
-        certificateStore.Open(OpenFlags.ReadWrite);
-
-        foreach (var installedCertificate in certificateStore.Certificates)
+        get
         {
-            var installedCertificateThumbprint = installedCertificate.GetCertHashString(HashAlgorithmName.SHA256);
-            if (LauncherCertificateThumbprint.Equals(installedCertificateThumbprint, OrdinalIgnoreCase)) return;
+            using X509Store store = new(StoreName.TrustedPeople, StoreLocation.LocalMachine);
+            store.Open(OpenFlags.ReadOnly);
+
+            foreach (var certificate in store.Certificates)
+            {
+                var thumbprint = certificate.GetCertHashString(HashAlgorithmName.SHA256);
+                if (LauncherCertificateThumbprint.Equals(thumbprint, OrdinalIgnoreCase)) return true;
+            }
+
+            return false;
         }
+    }
 
-        using X509Certificate2 launcherCertificate = new(await HttpService.GetBytesAsync(LauncherCertificateUri));
-        var launcherCertificateFingerprint = launcherCertificate.GetCertHashString(HashAlgorithmName.SHA256);
+    internal static Task InstallCertificateAsync() => Task.Run(static async () =>
+    {
+        if (!IsCertificateInstalled)
+        {
+            using X509Certificate2 certificate = new(await HttpService.GetBytesAsync(LauncherCertificateUri));
+            var thumbprint = certificate.GetCertHashString(HashAlgorithmName.SHA256);
 
-        if (!launcherCertificateFingerprint.Equals(LauncherCertificateThumbprint, OrdinalIgnoreCase))
-            throw new("The launcher's remote thumbprint doesn't match the installer's local thumbprint.");
+            if (!thumbprint.Equals(LauncherCertificateThumbprint, OrdinalIgnoreCase))
+                throw new SecurityException("The launcher's remote thumbprint doesn't match the installer's local thumbprint.");
 
-        certificateStore.Add(launcherCertificate);
+            using X509Store store = new(StoreName.TrustedPeople, StoreLocation.LocalMachine);
+            store.Open(OpenFlags.ReadWrite); store.Add(certificate);
+        }
     });
 
     internal static Task InstallPackageAsync(Action<int> callback) => Task.Run(() =>

src/MainWindow.cs

@@ -77,8 +77,8 @@ await InstallerService.InstallPackageAsync(value => Dispatcher.Invoke(() =>
 
         using (Process.Start(new ProcessStartInfo
         {
-            UseShellExecute= true,
-            FileName= @"shell:appsFolder\Flarial.Launcher_0jrgakbnj75vr!App"
+            UseShellExecute = true,
+            FileName = @"shell:appsFolder\Flarial.Launcher_0jrgakbnj75vr!App"
         })) { }
 
         Environment.Exit(0);