Skip to content

Commit 52f6148

Browse files
authored
chore: add priorities to profile settings page (#3657)
To give extensions more flexibility
1 parent dc215ab commit 52f6148

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

framework/core/js/src/forum/components/SettingsPage.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,15 @@ export default class SettingsPage<CustomAttrs extends IUserPageAttrs = IUserPage
4040
settingsItems() {
4141
const items = new ItemList<Mithril.Children>();
4242

43-
['account', 'notifications', 'privacy'].forEach((section) => {
43+
['account', 'notifications', 'privacy'].forEach((section, index) => {
4444
const sectionItems = `${section}Items` as 'accountItems' | 'notificationsItems' | 'privacyItems';
4545

4646
items.add(
4747
section,
4848
<FieldSet className={`Settings-${section}`} label={app.translator.trans(`core.forum.settings.${section}_heading`)}>
4949
{this[sectionItems]().toArray()}
50-
</FieldSet>
50+
</FieldSet>,
51+
100 - index * 10
5152
);
5253
});
5354

@@ -64,14 +65,16 @@ export default class SettingsPage<CustomAttrs extends IUserPageAttrs = IUserPage
6465
'changePassword',
6566
<Button className="Button" onclick={() => app.modal.show(ChangePasswordModal)}>
6667
{app.translator.trans('core.forum.settings.change_password_button')}
67-
</Button>
68+
</Button>,
69+
100
6870
);
6971

7072
items.add(
7173
'changeEmail',
7274
<Button className="Button" onclick={() => app.modal.show(ChangeEmailModal)}>
7375
{app.translator.trans('core.forum.settings.change_email_button')}
74-
</Button>
76+
</Button>,
77+
90
7578
);
7679

7780
return items;
@@ -83,7 +86,7 @@ export default class SettingsPage<CustomAttrs extends IUserPageAttrs = IUserPage
8386
notificationsItems() {
8487
const items = new ItemList<Mithril.Children>();
8588

86-
items.add('notificationGrid', <NotificationGrid user={this.user} />);
89+
items.add('notificationGrid', <NotificationGrid user={this.user} />, 100);
8790

8891
return items;
8992
}
@@ -109,7 +112,8 @@ export default class SettingsPage<CustomAttrs extends IUserPageAttrs = IUserPage
109112
loading={this.discloseOnlineLoading}
110113
>
111114
{app.translator.trans('core.forum.settings.privacy_disclose_online_label')}
112-
</Switch>
115+
</Switch>,
116+
100
113117
);
114118

115119
return items;

0 commit comments

Comments
 (0)