chore: address code review comments

Author: fkondej

custom-recipes/buildernet/mkosi/scripts/prepare.sh

@@ -33,7 +33,9 @@ mkdir -p "${RUNTIME_DIR}"
 
 if [[ "${SOURCE}" =~ ^https?:// ]]; then
     echo "prepare.sh: downloading from URL..."
-    curl -fSL -o "${VM_IMAGE}" "${SOURCE}"
+    TMP_IMAGE="${VM_IMAGE}.tmp"
+    curl -fSL -o "${TMP_IMAGE}" "${SOURCE}"
+    mv "${TMP_IMAGE}" "${VM_IMAGE}"
 elif [[ -f "${SOURCE}" ]]; then
     echo "prepare.sh: copying local file ($(du -h "${SOURCE}" | cut -f1))..."
     cp --sparse=always "${SOURCE}" "${VM_IMAGE}"
@@ -50,4 +52,4 @@ echo "prepare.sh: creating data disk..."
 qemu-img create -f raw "${VM_DATA_DISK}" 100G
 
 echo "prepare.sh: runtime ready"
-ls -lah "${RUNTIME_DIR}"
+ls -lah "${RUNTIME_DIR}"

custom-recipes/buildernet/mkosi/scripts/start.sh

@@ -41,9 +41,9 @@ if [[ "${ACCEL}" == "kvm" ]]; then
         echo "    (TCG is ~10-20x slower but works anywhere)"
         exit 1
     fi
-    QEMU_ACCEL_ARGS="-enable-kvm -cpu host"
+    QEMU_ACCEL_ARGS=(-enable-kvm -cpu host)
 elif [[ "${ACCEL}" == "tcg" ]]; then
-    QEMU_ACCEL_ARGS="-accel tcg -cpu max"
+    QEMU_ACCEL_ARGS=(-accel tcg -cpu max)
 else
     echo "Error: Unknown QEMU_ACCEL value: ${ACCEL} (expected 'kvm' or 'tcg')"
     exit 1
@@ -63,7 +63,7 @@ echo "  Console socket: ${CONSOLE_SOCK}"
 source "${SCRIPT_DIR}/ovmf.sh"
 
 echo "start.sh: launching qemu-system-x86_64..."
-echo "start.sh: QEMU_ACCEL_ARGS=${QEMU_ACCEL_ARGS}"
+echo "start.sh: QEMU_ACCEL_ARGS=${QEMU_ACCEL_ARGS[*]}"
 echo "start.sh: VM_IMAGE=${VM_IMAGE} ($(du -h "${VM_IMAGE}" | cut -f1))"
 echo "start.sh: VM_DATA_DISK=${VM_DATA_DISK}"
 
@@ -77,7 +77,7 @@ exec qemu-system-x86_64 \
   -drive if=pflash,format=raw,readonly=on,file="${OVMF_VARS}" \
   -drive format=qcow2,if=none,cache=none,id=osdisk,file="${VM_IMAGE}" \
   -device nvme,drive=osdisk,serial=nvme-os,bootindex=0 \
-  ${QEMU_ACCEL_ARGS} -m "${RAM}" -smp "${CPU}" -display none \
+  "${QEMU_ACCEL_ARGS[@]}" -m "${RAM}" -smp "${CPU}" -display none \
   -device virtio-scsi-pci,id=scsi0 \
   -drive file="${VM_DATA_DISK}",format=raw,if=none,id=datadisk \
   -device nvme,id=nvme0,serial=nvme-data \

playground/test_tx.go

@@ -241,11 +241,16 @@ func SendTestTransaction(ctx context.Context, cfg *TestTxConfig) error {
 				// Get block to show extra data (builder name)
 				block, err := elClient.BlockByNumber(ctx, receipt.BlockNumber)
 				if err == nil && block != nil {
-					extraData := string(block.Extra())
-					fmt.Printf("  Extra Data: %s\n", extraData)
-
-					if cfg.ExpectedExtraData != "" && extraData != cfg.ExpectedExtraData {
-						return fmt.Errorf("extra data mismatch: expected %q, got %q", cfg.ExpectedExtraData, extraData)
+					extraHex := hex.EncodeToString(block.Extra())
+					fmt.Printf("  Extra Data: 0x%s\n", extraHex)
+
+					if cfg.ExpectedExtraData != "" {
+						expectedHex := hex.EncodeToString([]byte(cfg.ExpectedExtraData))
+						if extraHex != expectedHex {
+							fmt.Printf("  Extra Data check: failed\n")
+							return fmt.Errorf("extra data mismatch: expected 0x%s (%q), got 0x%s", expectedHex, cfg.ExpectedExtraData, extraHex)
+						}
+						fmt.Printf("  Extra Data check: passed\n")
 					}
 				}
 				return nil