Conversation
|
Claude finished @fkondej's task in 1m 5s —— View job PR Review:
|
| if cfg.Insecure { | ||
| httpClient := &http.Client{ | ||
| Transport: &http.Transport{ | ||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, |
There was a problem hiding this comment.
Nit: consider adding a //nolint:gosec or // #nosec G402 comment on the InsecureSkipVerify: true line. Static analysis tools (gosec, staticcheck) will flag this. Adding the annotation makes it clear this is intentional and user-gated behind --insecure.
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec // user-requested via --insecure flag |
|
Claude finished @canercidam's task in 1m 32s —— View job PR Review:
|
| if cfg.Insecure { | ||
| httpClient := &http.Client{ | ||
| Transport: &http.Transport{ | ||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, |
There was a problem hiding this comment.
gosec is enabled in .golangci.yaml and G402 is not excluded, so this line will fail CI. Add a nolint directive:
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | |
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec // user-requested via --insecure flag |
No description provided.