Tweak BuilderNet recipe defaults#389
Tweak BuilderNet recipe defaults#389canercidam wants to merge 3 commits intofryd/improve-buildernet-mkosi-readmefrom
Conversation
|
Claude finished @canercidam's task in 34s —— View job Review
The change switches the default branch for the Potential concern: Defaulting to a feature branch ( Additionally, the script has a pre-existing gap: if No blocking issues — the change is correct for what it intends to do. |
|
Claude finished @canercidam's task in 46s —— View job Review
Two commits change the default Feature branch as default ( Stale clone not updated (
No blocking issues. |
|
Claude finished @canercidam's task in 59s —— View job Review
Three commits: default branch change in No new issues beyond what was flagged in prior reviews. The key concern remains the feature branch default ( One minor nit on the latest commit: the No blocking issues. |
| # - alternatively you can set this in playground.yaml (see below) | ||
| # 3. Build a VM image or point to it | ||
| # Build | ||
| ./scripts/build.sh |
There was a problem hiding this comment.
The BuilderNet VM should be built according to flashbots-images instructions. Those might change.
I have added builder.sh as an example, and it shouldnt be used as part of regular workflow.
No description provided.