Skip to content

Hiding custom recipes#390

Merged
canercidam merged 1 commit intomainfrom
caner/hidden-custom-recipes
Mar 2, 2026
Merged

Hiding custom recipes#390
canercidam merged 1 commit intomainfrom
caner/hidden-custom-recipes

Conversation

@canercidam
Copy link
Member

Easy feature to hide custom recipes from the recipes command while making them available from generate.

This allows us to temporarily hide any custom recipe until the experience stabilizes (currently using for buildernet/mkosi).

@claude
Copy link
Contributor

claude bot commented Mar 2, 2026

Claude finished @canercidam's task in 2m 36s —— View job


PR Review: Hiding custom recipes

  • Gather context and read changed files
  • Review code quality, bugs, edge cases
  • Post review feedback

Clean, well-scoped PR. One issue to flag:

Hidden recipes can still be started via startCmd.RunE fallback (main.go:92-108)

The main() function at line 580-584 filters hidden recipes from Cobra subcommand registration, but the startCmd.RunE fallback at lines 92-108 loads custom recipes directly from GetEmbeddedCustomRecipes() without checking Hidden. This means playground start buildernet/mkosi would still work through this path.

If the intent is to only hide from listings/help text, this is fine but worth a comment. If hidden recipes should also be blocked from start, the fallback needs a hidden check too.

Everything else looks correct — the generate command properly bypasses the hidden flag, and the recipes listing properly filters hidden entries.

@canercidam canercidam merged commit c93e707 into main Mar 2, 2026
7 checks passed
@canercidam canercidam deleted the caner/hidden-custom-recipes branch March 2, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants