You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hidden recipes can still be started via startCmd.RunE fallback (main.go:92-108)
The main() function at line 580-584 filters hidden recipes from Cobra subcommand registration, but the startCmd.RunE fallback at lines 92-108 loads custom recipes directly from GetEmbeddedCustomRecipes() without checking Hidden. This means playground start buildernet/mkosi would still work through this path.
If the intent is to only hide from listings/help text, this is fine but worth a comment. If hidden recipes should also be blocked from start, the fallback needs a hidden check too.
Everything else looks correct — the generate command properly bypasses the hidden flag, and the recipes listing properly filters hidden entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easy feature to hide custom recipes from the
recipescommand while making them available fromgenerate.This allows us to temporarily hide any custom recipe until the experience stabilizes (currently using for
buildernet/mkosi).