another check

Author: metachris

collector/tx_processor.go

@@ -255,13 +255,13 @@ func (p *TxProcessor) validateTx(fTrash *os.File, txIn common.TxIn) error { // i
 	txHashLower := strings.ToLower(tx.Hash().Hex())
 	log := p.log.With("tx_hash", txHashLower).With("source", txIn.Source)
 
-	// Make sure the transaction is signed properly.
 	if tx.ChainId().Sign() <= 0 {
 		log.Debugf("error: invalid chainID %w", tx.ChainId())
 		p.writeTrash(fTrash, txIn, "chainId not set", "")
-		return fmt.Errorf("chainId not set") //nolint:err113
+		return common.ErrChainIDNotSet
 	}
 
+	// Make sure the transaction is signed properly.
 	if _, err := types.Sender(types.LatestSignerForChainID(tx.ChainId()), tx); err != nil {
 		log.Debugw("error: transaction signature incorrect")
 		p.writeTrash(fTrash, txIn, common.TrashTxSignatureError, "")

common/errors.go

@@ -0,0 +1,5 @@
+package common
+
+import "errors"
+
+var ErrChainIDNotSet = errors.New("ChainID not set")

common/txsfile.go

@@ -153,6 +153,11 @@ func ParseTx(timestampMs int64, rawTxHex string) (TxSummaryEntry, *types.Transac
 		return TxSummaryEntry{}, nil, err
 	}
 
+	// Make sure the transaction is signed properly.
+	if tx.ChainId().Sign() <= 0 {
+		return TxSummaryEntry{}, nil, ErrChainIDNotSet
+	}
+
 	from, err := types.Sender(types.LatestSignerForChainID(tx.ChainId()), tx)
 	if err != nil {
 		// fmt.Println("Error: ", err)