Skip to content

"no bid received" info level log is misleading #869

@ThreeMuskets12

Description

@ThreeMuskets12

At least myself and one other person have been a bit mislead during the debugging process of trying to figure out why a block was built locally.

In the event that no bids were received that exceed the min-bid setting, with log level set at the default (above debug), the user will see the info level log "no bid received" that is triggered in handleGetHeader if result.response.isEmpty is true.

In reality, bids may have actually been received, but the "bid received" and the potential subsequent "ignoring bid below min-bid value" logs from inside getHeader are at debug level, and won't show up at the default log level above debug.

The info level log from handleGetHeader if result.response.isEmpty is true should better reflect the real meaning of having result.response.isEmpty, which might be something like "no acceptable bids received" or something like that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions