Skip to content

Commit 3e471ed

Browse files
authored
Removed wrong check (#599)
## 📝 Summary There was no real error and it was cancelling blocks. ## ✅ I have completed the following steps: * [X] Run `make lint` * [X] Run `make test` * [ ] Added tests (if applicable)
1 parent 21631c3 commit 3e471ed

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

crates/rbuilder/src/building/built_block_trace.rs

-10
Original file line numberDiff line numberDiff line change
@@ -101,20 +101,10 @@ impl BuiltBlockTrace {
101101
&self,
102102
blocklist: &HashSet<Address>,
103103
) -> Result<(), BuiltBlockTraceError> {
104-
let mut replacement_data_count: HashSet<_> = HashSet::default();
105104
let mut bundle_txs_scratchpad = HashMap::default();
106105
let mut executed_tx_hashes_scratchpad = Vec::new();
107106

108107
for res in &self.included_orders {
109-
for order in res.order.original_orders() {
110-
if let Some(data) = order.replacement_key() {
111-
if replacement_data_count.contains(&data) {
112-
return Err(BuiltBlockTraceError::DuplicateReplacementData(data));
113-
}
114-
replacement_data_count.insert(data);
115-
}
116-
}
117-
118108
if res.txs.len() != res.receipts.len() {
119109
return Err(BuiltBlockTraceError::DifferentTxsAndReceipts);
120110
}

crates/rbuilder/src/building/testing/bundle_tests/mod.rs

-26
Original file line numberDiff line numberDiff line change
@@ -585,32 +585,6 @@ fn test_bundle_consistency_check() -> eyre::Result<()> {
585585
assert!(err.to_string().contains("Bundle tx reverted"));
586586
}
587587

588-
// check commit of 2 bundles with the same replacement uuid
589-
{
590-
let replacement_data = BundleReplacementData {
591-
key: BundleReplacementKey::new(Uuid::from_u128(100), Some(Address::random())),
592-
sequence_number: 0,
593-
};
594-
let mut built_block_trace = BuiltBlockTrace::new();
595-
596-
test_setup.begin_bundle_order(11);
597-
test_setup.set_bundle_replacement_data(replacement_data.clone());
598-
test_setup.add_dummy_tx_0_1_no_rev()?;
599-
let res = test_setup.commit_order_ok();
600-
built_block_trace.add_included_order(res);
601-
602-
test_setup.begin_bundle_order(11);
603-
test_setup.set_bundle_replacement_data(replacement_data);
604-
test_setup.add_dummy_tx_0_1_no_rev()?;
605-
let res = test_setup.commit_order_ok();
606-
built_block_trace.add_included_order(res);
607-
608-
let err = built_block_trace
609-
.verify_bundle_consistency(&blocklist)
610-
.expect_err("Expected error");
611-
assert!(err.to_string().contains("replacement data"));
612-
}
613-
614588
// check commit of blocklisted tx from
615589
{
616590
let blocklist = vec![test_setup.named_address(NamedAddr::User(0))?]

0 commit comments

Comments
 (0)