Commit 6037fa7
authored
Correctly budget gas for refund payment in block to non-EOA recipient (#932)
## 📝 Summary
When calculating the payout gas budget of a non-EOA refund recipient,
`estimate_payout_gas_limit` used `tx_gas_limit_cap` (EIP-7825:
16,777,216) minus the gas used in the block. This caused bundles with
those refunds to fail once the block committed past ~16.7M gas, failing
with
`EstimatePayoutGas(PayoutTxErr(EvmError(Transaction(CallGasCostMoreThanGasLimit
{ initial_gas: 21000, gas_limit: 0 }))))`
Instead, the payout tx gas_limit needs to be at most the EIP-7825 limit,
or whatever is left in the block, whichever is less.
<!--- A general summary of your changes -->
## 💡 Motivation and Context
<!--- (Optional) Why is this change required? What problem does it
solve? Remove this section if not applicable. -->
prevent bundles from being dropped due to bad refund tx payout
calculation
---
## ✅ I have completed the following steps:
* [x] Run `make lint`
* [x] Run `make test`
* [x] Added tests (if applicable)1 parent 1daf074 commit 6037fa7
1 file changed
Lines changed: 61 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
181 | 184 | | |
182 | 185 | | |
183 | 186 | | |
| |||
189 | 192 | | |
190 | 193 | | |
191 | 194 | | |
192 | | - | |
| 195 | + | |
193 | 196 | | |
194 | 197 | | |
195 | 198 | | |
| |||
227 | 230 | | |
228 | 231 | | |
229 | 232 | | |
230 | | - | |
231 | | - | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
| |||
261 | 265 | | |
262 | 266 | | |
263 | 267 | | |
264 | | - | |
| 268 | + | |
265 | 269 | | |
266 | 270 | | |
267 | 271 | | |
| |||
273 | 277 | | |
274 | 278 | | |
275 | 279 | | |
| 280 | + | |
| 281 | + | |
276 | 282 | | |
277 | 283 | | |
278 | 284 | | |
279 | 285 | | |
280 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
281 | 310 | | |
282 | | - | |
283 | | - | |
284 | | - | |
285 | | - | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
286 | 334 | | |
287 | 335 | | |
0 commit comments