Skip to content

Commit af6ff8e

Browse files
authored
Merge pull request #81 from fleetbase/dev-v0.3.1
Dev v0.3.1
2 parents b5215c9 + 9903a32 commit af6ff8e

File tree

13 files changed

+438
-221
lines changed

13 files changed

+438
-221
lines changed

addon/components/autocomplete-input.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ import { action, computed } from '@ember/object';
55
import { later } from '@ember/runloop';
66
import { isBlank } from '@ember/utils';
77
import { isArray } from '@ember/array';
8-
import { timeout } from 'ember-concurrency';
9-
import { task } from 'ember-concurrency-decorators';
8+
import { timeout, task } from 'ember-concurrency';
109

1110
export default class AutocompleteInputComponent extends Component {
1211
@service fetch;

addon/components/comment-thread.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Component from '@glimmer/component';
22
import { tracked } from '@glimmer/tracking';
33
import { inject as service } from '@ember/service';
4-
import { task } from 'ember-concurrency-decorators';
4+
import { task } from 'ember-concurrency';
55
import getWithDefault from '@fleetbase/ember-core/utils/get-with-default';
66
import getModelName from '@fleetbase/ember-core/utils/get-model-name';
77

addon/components/comment-thread/comment.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Component from '@glimmer/component';
22
import { tracked } from '@glimmer/tracking';
33
import { action } from '@ember/object';
44
import { inject as service } from '@ember/service';
5-
import { task } from 'ember-concurrency-decorators';
5+
import { task } from 'ember-concurrency';
66

77
/**
88
* Component to handle individual comments in a comment thread.

addon/components/fetch-select.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ import { isEmpty } from '@ember/utils';
55
import { action, set } from '@ember/object';
66
import { isArray } from '@ember/array';
77
import { assert } from '@ember/debug';
8-
import { timeout } from 'ember-concurrency';
9-
import { restartableTask } from 'ember-concurrency-decorators';
8+
import { timeout, restartableTask } from 'ember-concurrency';
109

1110
/**
1211
* FetchSelectComponent is a Glimmer component responsible for rendering a
@@ -75,7 +74,7 @@ export default class FetchSelectComponent extends Component {
7574
* @param {boolean} [initialLoad=false] - Whether this is the initial load.
7675
* @task
7776
*/
78-
@restartableTask({ withTestWaiter: true }) searchOptions = function* (term, options = {}, initialLoad = false) {
77+
@restartableTask() searchOptions = function* (term, options = {}, initialLoad = false) {
7978
if (!initialLoad) {
8079
yield timeout(this.debounceDuration);
8180
}
@@ -90,7 +89,7 @@ export default class FetchSelectComponent extends Component {
9089
* @param {Object} [options={}] - Additional options for the fetch.
9190
* @task
9291
*/
93-
@restartableTask({ withTestWaiter: true }) fetchOptions = function* (term, options = {}) {
92+
@restartableTask() fetchOptions = function* (term, options = {}) {
9493
// query might be an EmptyObject/{{hash}}, make it a normal Object
9594
const query = Object.assign({}, this.args.query);
9695

addon/components/locale-selector-tray.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { tracked } from '@glimmer/tracking';
33
import { inject as service } from '@ember/service';
44
import { action } from '@ember/object';
55
import { debug } from '@ember/debug';
6-
import { task } from 'ember-concurrency-decorators';
6+
import { task } from 'ember-concurrency';
77
import calculatePosition from 'ember-basic-dropdown/utils/calculate-position';
88

99
export default class LocaleSelectorTrayComponent extends Component {

addon/components/model-select.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ import { action, get, set } from '@ember/object';
44
import { inject as service } from '@ember/service';
55
import { A } from '@ember/array';
66
import { tracked } from '@glimmer/tracking';
7-
import { timeout } from 'ember-concurrency';
8-
import { restartableTask, dropTask } from 'ember-concurrency-decorators';
7+
import { timeout, restartableTask, dropTask } from 'ember-concurrency';
98
import generateUuid from '@fleetbase/ember-core/utils/generate-uuid';
109
import config from 'ember-get-config';
1110

@@ -160,7 +159,7 @@ export default class ModelSelectComponent extends Component {
160159
this.selectedModel = selectedModel;
161160
}
162161

163-
@dropTask({ withTestWaiter: true }) findRecord = function* (modelName, id) {
162+
@dropTask findRecord = function* (modelName, id) {
164163
// this wrapper task is requried to avoid the following error upon fast changes
165164
// of selectedModel:
166165
// Error: Assertion Failed: You attempted to remove a function listener which
@@ -172,7 +171,7 @@ export default class ModelSelectComponent extends Component {
172171
return resolvedModel;
173172
};
174173

175-
@restartableTask({ withTestWaiter: true }) searchModels = function* (term, options, initialLoad = false) {
174+
@restartableTask searchModels = function* (term, options, initialLoad = false) {
176175
if (this.doesntHavePermissions || this.disabled) {
177176
return;
178177
}
@@ -195,7 +194,7 @@ export default class ModelSelectComponent extends Component {
195194
yield this.loadModels.perform(term, createOption);
196195
};
197196

198-
@restartableTask({ withTestWaiter: true }) loadModels = function* (term, createOption) {
197+
@restartableTask loadModels = function* (term, createOption) {
199198
if (this.doesntHavePermissions || this.disabled) {
200199
return;
201200
}

addon/components/phone-input.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Component from '@glimmer/component';
22
import { tracked } from '@glimmer/tracking';
33
import { inject as service } from '@ember/service';
44
import { action } from '@ember/object';
5+
import { debug } from '@ember/debug';
56
import intlTelInput from 'intl-tel-input';
67

78
export default class PhoneInputComponent extends Component {
@@ -14,13 +15,14 @@ export default class PhoneInputComponent extends Component {
1415
initialCountry: 'auto',
1516
separateDialCode: true,
1617
formatAsYouType: true,
17-
geoIpLookup: (success, failure) => {
18-
this.fetch
19-
.get('lookup/whois')
20-
.then((response) => {
21-
success(response.country_code);
22-
})
23-
.catch(failure);
18+
geoIpLookup: async (success, failure) => {
19+
try {
20+
const { country_code } = await this.fetch.get('lookup/whois');
21+
success(country_code);
22+
} catch (error) {
23+
debug('Failed to lookup country code with whois API.');
24+
failure(error);
25+
}
2426
},
2527
utilsScript: '/assets/libphonenumber/utils.js',
2628
});

addon/initializers/define-task-test-waiter-modifier.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import defineModifier from 'ember-concurrency-test-waiter/define-modifier';
1+
// import defineModifier from 'ember-concurrency-test-waiter/define-modifier';
22

33
export function initialize() {
4-
defineModifier();
4+
// defineModifier();
55
}
66

77
export default {

addon/services/dashboard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Service from '@ember/service';
22
import { inject as service } from '@ember/service';
33
import { tracked } from '@glimmer/tracking';
4-
import { task } from 'ember-concurrency-decorators';
4+
import { task } from 'ember-concurrency';
55
import { action } from '@ember/object';
66
import { isArray } from '@ember/array';
77

addon/styles/addon.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,6 @@
4848
@import 'components/tip-tap-editor.css';
4949

5050
/** Third party */
51+
@import "ember-basic-dropdown/vendor/ember-basic-dropdown.css";
52+
@import 'ember-power-select/vendor/ember-power-select.css';
5153
@import 'air-datepicker/air-datepicker.css';

0 commit comments

Comments
 (0)