chore: Improve CI robustness, bump and enforce MSRV (#10)

* bump MSRV to 1.75, add it to `Cargo.toml` manifests

* CI: add `msrv` job

* CI: rename `build_and_test` job to `cross_platform_tests` and add extra checks

* envoy-types: generate well-known types corresponding to `protoc` v29.3

Author: flemosr

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - run: cargo clippy --workspace --all-features --all-targets
 
-  build_and_test:
+  cross_platform_tests:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -41,8 +41,37 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: hecrj/setup-rust-action@v2
+        with:
+          rust-version: ${{ matrix.toolchain }}
       - uses: taiki-e/install-action@protoc
       - uses: Swatinem/rust-cache@v2
-      - run: rustup update ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }}
-      - run: cargo build --verbose
-      - run: cargo test --doc --all-features --verbose 
+      - run: cargo test --all-features
+      - uses: taiki-e/install-action@cargo-no-dev-deps
+      - run: cargo no-dev-deps --no-private check --all-features
+      - run: cargo no-dev-deps --no-private doc --no-deps --all-features
+        env:
+          RUSTDOCFLAGS: "-D warnings"
+
+  msrv:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: hecrj/setup-rust-action@v2
+    - run: cargo update
+      env:
+        CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: fallback
+    - name: Get MSRV from metadata
+      id: msrv
+      run: |
+        MSRV=$(cargo metadata --no-deps --format-version 1 | jq -r '.packages[0].rust_version')
+        echo "version=${MSRV}" >> $GITHUB_OUTPUT
+    - uses: hecrj/setup-rust-action@v2
+      with:
+        rust-version: ${{ steps.msrv.outputs.version }}
+    - uses: Swatinem/rust-cache@v2
+    - run: cargo check --all-features
+    - uses: taiki-e/install-action@cargo-no-dev-deps
+    - run: cargo no-dev-deps --no-private check --all-features
+    - run: cargo no-dev-deps --no-private doc --no-deps --all-features
+      env:
+        RUSTDOCFLAGS: "-D warnings"

Cargo.toml

@@ -1,3 +1,6 @@
 [workspace]
 members = ["envoy-proto-collect", "envoy-types", "examples"]
 resolver = "2"
+
+[workspace.package]
+rust-version = "1.75"

README.md

@@ -17,7 +17,7 @@ Among other use cases, this crate can be used to implement an
 
 ### Rust Version
 
-This project's MSRV is `1.71.1`.
+This project's MSRV is `1.75`.
 
 ### Dependencies
 

envoy-proto-collect/Cargo.toml

@@ -4,6 +4,7 @@ authors = ["Rafael Lemos <contact@flemosr.com"]
 edition = "2021"
 license = "Apache-2.0"
 publish = false
+rust-version = { workspace = true }
 version = "0.1.0"
 
 [[bin]]

envoy-types/Cargo.toml

@@ -12,6 +12,7 @@ keywords = ["rpc", "grpc", "async", "envoy", "extauthz"]
 license = "Apache-2.0"
 readme = "../README.md"
 repository = "https://github.com/flemosr/envoy-types"
+rust-version = { workspace = true }
 version = "0.5.3"
 
 [dependencies]

envoy-types/src/generated/google.protobuf.rs

@@ -850,12 +850,13 @@ pub struct MessageOptions {
 }
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct FieldOptions {
+    /// NOTE: ctype is deprecated. Use `features.(pb.cpp).string_type` instead.
     /// The ctype option instructs the C++ code generator to use a different
     /// representation of the field than it normally would.  See the specific
     /// options below.  This option is only implemented to support use of
     /// \[ctype=CORD\] and \[ctype=STRING\] (the default) on non-repeated fields of
-    /// type "bytes" in the open source release -- sorry, we'll try to include
-    /// other types in a future version!
+    /// type "bytes" in the open source release.
+    /// TODO: make ctype actually deprecated.
     #[prost(
         enumeration = "field_options::CType",
         optional,
@@ -1073,8 +1074,6 @@ pub mod field_options {
         }
     }
     /// If set to RETENTION_SOURCE, the option will be omitted from the binary.
-    /// Note: as of January 2023, support for this is in progress and does not yet
-    /// have an effect (b/264593489).
     #[derive(
         Clone,
         Copy,
@@ -1116,8 +1115,7 @@ pub mod field_options {
     }
     /// This indicates the types of entities that the field may apply to when used
     /// as an option. If it is unset, then the field may be freely used as an
-    /// option on any kind of entity. Note: as of January 2023, support for this is
-    /// in progress and does not yet have an effect (b/264593489).
+    /// option on any kind of entity.
     #[derive(
         Clone,
         Copy,
@@ -1907,7 +1905,7 @@ pub enum Edition {
     Edition2023 = 1000,
     Edition2024 = 1001,
     /// Placeholder editions for testing feature resolution.  These should not be
-    /// used or relyed on outside of tests.
+    /// used or relied on outside of tests.
     Edition1TestOnly = 1,
     Edition2TestOnly = 2,
     Edition99997TestOnly = 99997,

envoy-types/src/generated/types.bin

@@ -9,7 +9,7 @@ Among other use cases, this crate can be used to implement an
 
 ### Rust Version
 
-This project's MSRV is `1.71.1`.
+This project's MSRV is `1.75`.
 
 ### Dependencies
 

envoy-types/src/lib.rs

@@ -4,6 +4,7 @@ authors = ["Rafael Lemos <contact@flemosr.com"]
 edition = "2021"
 license = "Apache-2.0"
 publish = false
+rust-version = { workspace = true }
 version = "0.1.0"
 
 [[example]]