Skip to content

Commit f9a5f6c

Browse files
Fix: do not remove flutter-packages on re-build if dev_packages configured. (#5002)
1 parent 244a449 commit f9a5f6c

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Flet changelog
22

3+
## 0.27.4
4+
5+
* Fix: do not remove `flutter-packages` on re-build if `dev_packages` configured.
6+
37
## 0.27.3
48

59
* Fixes to make `flet build` work in CI environment ([#4993](https://github.com/flet-dev/flet/issues/4993))

packages/flet/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 0.27.4
2+
3+
* Fix: do not remove `flutter-packages` on re-build if `dev_packages` configured.
4+
15
# 0.27.3
26

37
* Fixes to make `flet build` work in CI environment ([#4993](https://github.com/flet-dev/flet/issues/4993))

packages/flet/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: flet
22
description: Write entire Flutter app in Python or add server-driven UI experience into existing Flutter app.
33
homepage: https://flet.dev
44
repository: https://github.com/flet-dev/flet/packages/flet
5-
version: 0.27.3
5+
version: 0.27.4
66

77
# This package supports all platforms listed below.
88
platforms:

sdk/python/packages/flet-cli/src/flet_cli/commands/build.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1731,25 +1731,24 @@ def package_python_app(self):
17311731
if platform_dependencies:
17321732
toml_dependencies.extend(platform_dependencies)
17331733

1734+
dev_packages_configured = False
17341735
if len(toml_dependencies) > 0:
17351736
dev_packages = (
17361737
self.get_pyproject(f"tool.flet.{self.config_platform}.dev_packages")
17371738
or self.get_pyproject(f"tool.flet.dev_packages")
17381739
or []
17391740
)
17401741
if len(dev_packages) > 0:
1741-
no_cache = False
17421742
for i in range(0, len(toml_dependencies)):
17431743
package_name = Requirement(toml_dependencies[i]).name
17441744
if package_name in dev_packages:
17451745
dev_path = Path(dev_packages[package_name])
17461746
if not dev_path.is_absolute():
17471747
dev_path = (self.python_app_path / dev_path).resolve()
17481748
toml_dependencies[i] = f"{package_name} @ file://{dev_path}"
1749-
no_cache = True
1750-
if no_cache:
1749+
dev_packages_configured = True
1750+
if dev_packages_configured:
17511751
toml_dependencies.append("--no-cache-dir")
1752-
hash.update(time.time())
17531752

17541753
package_args.append(",".join(toml_dependencies))
17551754

@@ -1857,11 +1856,13 @@ def package_python_app(self):
18571856
# check if site-packages installation could be skipped
18581857
for arg in package_args:
18591858
hash.update(arg)
1860-
if not hash.has_changed():
1861-
package_args.append("--skip-site-packages")
1862-
else:
1863-
if self.flutter_packages_dir.exists():
1864-
shutil.rmtree(self.flutter_packages_dir, ignore_errors=True)
1859+
1860+
if not dev_packages_configured:
1861+
if not hash.has_changed():
1862+
package_args.append("--skip-site-packages")
1863+
else:
1864+
if self.flutter_packages_dir.exists():
1865+
shutil.rmtree(self.flutter_packages_dir, ignore_errors=True)
18651866

18661867
package_result = self.run(
18671868
package_args,

0 commit comments

Comments
 (0)