Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falcon-40b model loading does not work -- file_loader expects incorrect model structure #1266

Open
ktorkkola opened this issue Jan 9, 2024 · 1 comment · May be fixed by #1272
Open

falcon-40b model loading does not work -- file_loader expects incorrect model structure #1266

ktorkkola opened this issue Jan 9, 2024 · 1 comment · May be fixed by #1272
Assignees
Labels
enhancement New feature or request

Comments

@ktorkkola
Copy link

file_loader.cc expects to find converted weights files corresponding to falcon-7b model structure, but they don't exist in falcon-40b:

Done converting the weights...
Loading weight file word_embeddings_weight
Loading weight file layers_0_input_layernorm_weight
Could not open file: /tmp/mymodel/half-precision/layers_0_input_layernorm_weight
python: /tmp/pip-install-toyyxtv8/flexflow_209f7d4f52cb40178d7cc442e662a167/inference/file_loader.cc:347: void
load_from_file(DT*, size_t, std::string) [with DT = __half; size_t = long unsigned int; std::string = std::__cxx11::basic_string]: Assertion `in.good() && "incorrect weight file path"' failed.

Falcon-40b has no such weights:
https://huggingface.co/tiiuae/falcon-40b/blob/main/pytorch_model.bin.index.json
whereas Falcon-7b has them:
https://huggingface.co/tiiuae/falcon-7b/blob/main/pytorch_model.bin.index.json

So file_loader seems to expect both models to follow falcon-7b structure but falcon-40b is different.

@goliaro
Copy link
Collaborator

goliaro commented Jan 9, 2024

Good catch! We'll push a fix

@jiazhihao jiazhihao added the enhancement New feature or request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants