Skip to content

Plans for using native Promises? #47

@spurreiter

Description

@spurreiter

Hi Jeremy,

Do you have any plans to use native promises with your library? Greater node 8 they are pretty much faster then js implementations like bluebird.

Today we encountered a strange problem with bluebird which we could not
nail down to a PoC. While recording a tape the response was not finally written
to disk but the Promise already resolved, such require(file) returned an empty response resulting in a "TypeError tape is not a function". Removing bluebird from lib/buffer.js solved the issue for us.
For the urgency we had to move forward, we created the fork at https://github.com/spurreiter/yakbak-native-promise which has bluebird replaced with native promises. Are you interested in a PR?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions