Description
Which version of floccus are you using?
5.4.3 on Firefox / 5.4.2 on Edge
How many bookmarks do you have, roughly?
300
Are you using other means to sync bookmarks in parallel to floccus?
Yes, I sync Firefox and Edge to their respective built-in primary backends
Sync method
Google Drive
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Firefox 134.0.1 / Edge 132.0.2957.115
Which version of Nextcloud Bookmarks are you using? (if relevant)
n/a
Which version of Nextcloud? (if relevant)
n/a
What kind of WebDAV server are you using? (if relevant)
n/a
Describe the Bug
Hi team!
Thank you for providing this tool. I appreciate your work!
Note:
This investigation is based on Edge (version as listed), but I expect the problem will be identical for all Chrome-based browsers.)
The Chrome-based browsers are lacking bookmark separators, and Floccus does a reasonable job emulating them by inserting a favicon-based "hack".
This "hack" works fine in most cases, however, it fails in the Favorites-bar.
There, the "icon" should be vertical rather than horizontal, and there should be no description text.
Currently, the bar looks like this:
Expected Behavior
The separators should be vertical, and there should be no other text on those elements.
Here is how the same synchronization looks for me in Firefox:
Contribution:
To contribute to a swift resolution, I created a PR for the separator-site repo: floccusaddon/separator-site#2
Suggestion:
It seems that the fix should be simple:
- Merge the above separator site PR.
- Here, use
title: ''
andurl: 'https://separator.floccus.org/vertical.html?id=${rng.int(0,1000000)}'
whenparentId === 'toolbar_____'
. - (Optional) When
parentId !== 'toolbar_____'
, usetitle: '⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯'
. This creates a more coherent horizontal separator line. (These are eleven Horizontal Line Extension chars (U+23AF).)
If this strategy seems reasonable, I'd be happy to create a PR after the separator site is merged. Please let me know if that is helpful.
Request:
Please, validate the fix not only for Chrome, but also for Edge, and possible for other common Chrome-based browsers.
To Reproduce
- Using Firefox, create a few bookmarks on the Bookmarks Toolbar, and make sure they are separated by separators.
- Sync that to Edge (or Chrome).
Debug log provided
- I have provided a debug log file
-- N/A
Extra request
The text on the vertical separators on places other than the Bookmarks Bar could be a little longer.
Currently it is: "-----
".
Suggestion: "⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
" (these are eleven Horizontal Line Extension chars (U+23AF)).