cert-manager-webhook-ovh/main_test.go at main · florent1s/cert-manager-webhook-ovh · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
package main

import (
	"testing"

	// acmetest "github.com/cert-manager/cert-manager/test/acme"
	corev1 "k8s.io/api/core/v1"
)

func TestValidate(t *testing.T) {
	s := &ovhDNSProviderSolver{}

	// fixture := acmetest.NewFixture(&ovhDNSProviderSolver{},
	// 	acmetest.SetResolvedZone(zone),
	// 	acmetest.SetAllowAmbientCredentials(false),
	// 	acmetest.SetManifestPath("testdata/ovh"),
	// )

	//need to uncomment and  RunConformance delete runBasic and runExtended once https://github.com/cert-manager/cert-manager/pull/4835 is merged
	// fixture.RunConformance(t)
	// fixture.RunBasic(t)
	// fixture.RunExtended(t)

	// No endpoint provided
	err := s.validate(&ovhDNSProviderConfig{}, false)
	if err == nil || err.Error() != "no endpoint provided in OVH config" {
		t.Errorf("expected missing endpoint error, got %v", err)
	}

	// No application key
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "application",
	}, false)
	if err == nil || err.Error() != "no application key provided in OVH config" {
		t.Errorf("expected application key error, got %v", err)
	}

	// No application secret
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "application",
		ApplicationKeyRef:    corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationKey"}},
	}, false)
	if err == nil || err.Error() != "no application secret provided in OVH config" {
		t.Errorf("expected application secret error, got %v", err)
	}

	// No consumer key nor application consumer key
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "application",
		ApplicationKeyRef:    corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationKey"}},
		ApplicationSecretRef: corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationSecret"}},
	}, false)
	if err == nil || err.Error() != "no application consumer key provided in OVH config" {
		t.Errorf("expected consumer key error, got %v", err)
	}

	// No OAuth2 Client ID
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "oauth2",
	}, false)
	if err == nil || err.Error() != "no oauth2 client ID provided in OVH config" {
		t.Errorf("expected oauth2 clientID error, got %v", err)
	}

	// No OAuth2 Client Secret
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "oauth2",
		Oauth2ClientIDRef:    corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "oauth2ClientId"}},
	}, false)
	if err == nil || err.Error() != "no oauth2 client secret provided in OVH config" {
		t.Errorf("expected oauth2 client secret error, got %v", err)
	}

	// Invalid Authentication Method
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:             "ovh-eu",
		AuthenticationMethod: "foo",
	}, false)
	if err == nil || err.Error() != "invalid value for authentifaction method, allowed values: 'application' and 'oauth2'" {
		t.Errorf("expected invalid method error, got %v", err)
	}

	// Valid configuration for Application
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:                  "ovh-eu",
		AuthenticationMethod:      "application",
		ApplicationKeyRef:         corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationKey"}},
		ApplicationSecretRef:      corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationSecret"}},
		ApplicationConsumerKeyRef: corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "applicationCustomerKey"}},
	}, false)
	if err != nil {
		t.Errorf("expected no error, got %v", err)
	}

	// Valid configuration for OAuth2
	err = s.validate(&ovhDNSProviderConfig{
		Endpoint:              "ovh-eu",
		AuthenticationMethod:  "oauth2",
		Oauth2ClientIDRef:     corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "oauth2ClientId"}},
		Oauth2ClientSecretRef: corev1.SecretKeySelector{LocalObjectReference: corev1.LocalObjectReference{Name: "oauth2ClientSecret"}},
	}, false)
	if err != nil {
		t.Errorf("expected no error, got %v", err)
	}
}