Merge pull request #13 from flowglad/refactor/sqlite3-patch-rename

patches: rename sqlite3-worker → sqlite3-dot-commands

Author: subsetpark

README.md

@@ -12,7 +12,7 @@
 >
 > | Patch | What it fixes | Upstream PR |
 > | --- | --- | --- |
-> | `sqlite3-worker` | The published npm tarball omits `dist/commands/sqlite3/worker.js`, so the bundled `sqlite3` command falls through to the Python worker and throws on every invocation. We ship the worker. | _filed in Patch 2_ |
+> | `sqlite3-dot-commands` | sql.js doesn't implement sqlite3's CLI dot-commands (`.tables`, `.schema`, `.mode`, `.read`, `.separator`, `.quit`, etc.), so agent scripts pasted from real `sqlite3` sessions hit syntax errors. We carry a preprocessor (`commands/sqlite3/dot-commands.ts`) that translates each dot-command to equivalent SQL, formatter-state mutations, recursive `.read` inlining, or actionable in-band error messages before handing the script to the worker. (The original `sqlite3-worker` bundling bug was upstreamed in [vercel-labs#190](https://github.com/vercel-labs/just-bash/pull/190).) | _filed in Patch 2_ |
 > | `awk-comma-continuation` | The bundled awk lexer emits a `NEWLINE` token after a trailing comma, breaking POSIX comma-continuation in scripts our agent runs. | _filed in Patch 2_ |
 > | `jq-permissive-control-chars` | The bundled jq input scanner calls `JSON.parse` on raw bytes that may contain literal control characters (which Shopify's Admin API responses do), failing parse. We sanitize the slice before parsing. | _filed in Patch 2_ |
 >

packages/just-bash/src/flowglad-patches.integration.test.ts

@@ -5,41 +5,57 @@ import { Bash } from "./Bash.js";
 // Adding a new patch requires adding a corresponding describe block here so
 // the consumability CI gates the next release on it.
 describe("Flowglad carried patches", () => {
-  describe("sqlite3-worker", () => {
-    it("ships the bundled worker so basic SQL runs", async () => {
+  describe("sqlite3-dot-commands", () => {
+    it("translates the .tables dot-command into a sqlite_master query", async () => {
       const env = new Bash();
 
       const result = await env.exec(
-        'sqlite3 :memory: "CREATE TABLE t(x); INSERT INTO t VALUES(42); SELECT x FROM t"',
+        'sqlite3 :memory: "CREATE TABLE alpha(x); CREATE TABLE beta(y); .tables"',
       );
 
       expect(result.stderr).toBe("");
-      expect(result.stdout).toBe("42\n");
+      expect(result.stdout).toBe("alpha\nbeta\n");
       expect(result.exitCode).toBe(0);
     });
 
-    it("translates the .tables dot-command into a sqlite_master query", async () => {
+    it("translates the .schema dot-command into a sqlite_master query", async () => {
       const env = new Bash();
 
       const result = await env.exec(
-        'sqlite3 :memory: "CREATE TABLE alpha(x); CREATE TABLE beta(y); .tables"',
+        'sqlite3 :memory: "CREATE TABLE alpha(x INTEGER); .schema alpha"',
       );
 
       expect(result.stderr).toBe("");
-      expect(result.stdout).toBe("alpha\nbeta\n");
+      // .schema appends `;` to each CREATE statement to match real sqlite3.
+      expect(result.stdout).toBe("CREATE TABLE alpha(x INTEGER);\n");
       expect(result.exitCode).toBe(0);
     });
 
-    it("translates the .schema dot-command into a sqlite_master query", async () => {
+    it(".mode csv mutates the formatter for downstream SQL", async () => {
       const env = new Bash();
 
       const result = await env.exec(
-        'sqlite3 :memory: "CREATE TABLE alpha(x INTEGER); .schema alpha"',
+        'sqlite3 :memory: "CREATE TABLE t(a,b); INSERT INTO t VALUES(1,2),(3,4); .mode csv\nSELECT * FROM t"',
       );
 
       expect(result.stderr).toBe("");
-      // .schema appends `;` to each CREATE statement to match real sqlite3.
-      expect(result.stdout).toBe("CREATE TABLE alpha(x INTEGER);\n");
+      expect(result.stdout).toBe("1,2\n3,4\n");
+      expect(result.exitCode).toBe(0);
+    });
+
+    it(".read inlines the contents of a referenced script", async () => {
+      const env = new Bash({
+        files: {
+          "/seed.sql": "CREATE TABLE t(x);\nINSERT INTO t VALUES(7);\n",
+        },
+      });
+
+      const result = await env.exec(
+        'sqlite3 :memory: ".read /seed.sql\nSELECT x FROM t"',
+      );
+
+      expect(result.stderr).toBe("");
+      expect(result.stdout).toBe("7\n");
       expect(result.exitCode).toBe(0);
     });
   });