Runner should be removed before termination (machulav#161)

garbas · garbas · commit f8fe7f55d55c · 2023-10-10T23:04:19.000+02:00
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated. machulav#161
diff --git a/src/index.js b/src/index.js
@@ -18,8 +18,8 @@ async function start() {
 }
 
 async function stop() {
-  await aws.terminateEc2Instance();
   await gh.removeRunner();
+  await aws.terminateEc2Instance();
 }
 
 (async function () {

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@ async function start() {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`async function stop() {`
`21`		`- await aws.terminateEc2Instance();`
`22`	`21`	`await gh.removeRunner();`
	`22`	`+ await aws.terminateEc2Instance();`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`(async function () {`