Skip to content

Commit 0b177aa

Browse files
committed
fix: upgrade esbuild-node-externals and mock-fs deps
1 parent c32aa53 commit 0b177aa

File tree

3 files changed

+18
-24
lines changed

3 files changed

+18
-24
lines changed

package-lock.json

Lines changed: 15 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,13 @@
8585
"@types/serverless": "^3.12.14",
8686
"all-contributors-cli": "^6.24.0",
8787
"esbuild": "^0.24.0",
88-
"esbuild-node-externals": "^1.14.0",
88+
"esbuild-node-externals": "^1.15.0",
8989
"eslint": "^8.56.0",
9090
"extract-zip": "^2.0.1",
9191
"husky": "^8.0.2",
9292
"jest": "^29.3.1",
9393
"lint-staged": "^13.1.0",
94-
"mock-fs": "^5.2.0",
94+
"mock-fs": "^5.3.0",
9595
"mock-spawn": "^0.2.6",
9696
"prettier": "^2.8.1",
9797
"semantic-release": "^19.0.5",
@@ -111,7 +111,6 @@
111111
"node": ">=18.0.0"
112112
},
113113
"overrides": {
114-
"esbuild": "$esbuild",
115114
"eslint": "$eslint"
116115
}
117116
}

src/tests/util.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// eslint-disable-next-line eslint-comments/disable-enable-pair
2-
/* eslint-disable jest/no-standalone-expect */
31
import fs from 'fs-extra';
42
import mockFs from 'mock-fs';
53
import path from 'path';
@@ -19,9 +17,6 @@ describe('utils/findProjectRoot', () => {
1917
});
2018
});
2119

22-
const nodeVersion = parseInt(process.versions.node.split('.')[0]!, 10);
23-
const itNode18 = nodeVersion > 18 ? it.skip : it;
24-
2520
describe('utils/zip', () => {
2621
const mtime = new Date(2024, 0, 1, 0, 0, 0, 0);
2722

@@ -67,7 +62,7 @@ describe('utils/zip', () => {
6762
await expect(zip(zipPath, filesPathList)).rejects.toThrow("ENOENT, no such file or directory '/src/incorrect.txt'");
6863
});
6964

70-
itNode18.each([{ useNativeZip: true }, { useNativeZip: false }])(
65+
it.each([{ useNativeZip: true }, { useNativeZip: false }])(
7166
'should properly archive files when useNativeZip=$useNativeZip.',
7267
async ({ useNativeZip }) => {
7368
const source = '/src';

0 commit comments

Comments
 (0)