Skip to content

bug: inconsistent behaviour for setting FluentBit labels and annotations #1424

Open
@jjsiv

Description

@jjsiv

Describe the issue

Setting FluentBit.Spec.Labels will set labels on both the DaemonSet and the pods.
Setting FluentBit.Spec.Annotations will set annotations only on the pods.

To Reproduce

Create a FluentBit resource with both labels and annotations

Expected behavior

Consistent behaviour for both of the options. Perhaps annotations should as well set the annotations on both the Daemonset and pods

Your Environment

- Fluent Operator version:
- Container Runtime:
- Operating system:
- Kernel version:

How did you install fluent operator?

No response

Additional context

Maybe append fb.Annotations and fb.Spec.Annotations and then set?
https://github.com/fluent/fluent-operator/blob/master/pkg/operator/daemonset.go#L36

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions