-
Notifications
You must be signed in to change notification settings - Fork 1.4k
TLS1.3 support for out_http
#4859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Athishpranav2003 <[email protected]>
Signed-off-by: Athishpranav2003 <[email protected]>
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
@Athishpranav2003 This PR is in draft status. Please let me know if there are any TODO. |
Hey @daipom I guess the pr is left to be tested but I didn't get time to test. Maybe I can check it next week but if someone else can do it as well it will be really helpful. Setting up the openssl thing I didn't try it |
OK! Thanks! |
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 7 days |
@@ -48,7 +48,7 @@ module TLS | |||
MIN_MAX_AVAILABLE = false | |||
map | |||
end | |||
private_constant :METHODS_MAP | |||
# private_constant :METHODS_MAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of publishing private, it might be better to provide min / max accessor
Which issue(s) this PR fixes:
Fixes #4332
What this PR does / why we need it:
Changes the way we configure Net::HTTP client.
Docs Changes:
N/A
Release Note:
N/A