Skip to content

Commit e19b148

Browse files
VitorCiolettiVitorCioletti
committed
Removed ITimeCalculator cast in unit tests.
1 parent 6af325d commit e19b148

File tree

15 files changed

+155
-269
lines changed

15 files changed

+155
-269
lines changed

‎FluentScheduler.UnitTests/Cron/CronTimeCalculatorTests.cs‎

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ public class CronTimeCalculatorTests
1111
public void At0405()
1212
{
1313
// Arrange
14-
var cronCalculator = new CronTimeCalculator("5 4 * * *");
15-
var calculator = (ITimeCalculator)cronCalculator;
14+
var calculator = new CronTimeCalculator("5 4 * * *");
1615

1716
var date = new DateTime(2018, 12, 22);
1817
var expected = new DateTime(2018, 12, 22, 4, 5, 0);
@@ -28,8 +27,7 @@ public void At0405()
2827
public void At0005InAugust()
2928
{
3029
// Arrange
31-
var cronCalculator = new CronTimeCalculator("5 0 * 8 *");
32-
var calculator = (ITimeCalculator)cronCalculator;
30+
var calculator = new CronTimeCalculator("5 0 * 8 *");
3331

3432
var date = new DateTime(2018, 12, 22);
3533
var expected = new DateTime(2019, 8, 1, 0, 5, 0);
@@ -45,8 +43,7 @@ public void At0005InAugust()
4543
public void At0405OnSunday()
4644
{
4745
// Arrange
48-
var cronCalculator = new CronTimeCalculator("5 4 * * sun");
49-
var calculator = (ITimeCalculator)cronCalculator;
46+
var calculator = new CronTimeCalculator("5 4 * * sun");
5047

5148
var date = new DateTime(2018, 12, 22);
5249
var expected = new DateTime(2018, 12, 23, 4, 5, 0);
@@ -62,8 +59,7 @@ public void At0405OnSunday()
6259
public void At0400OnEveryDayOfMonthFrom8Through14()
6360
{
6461
// Arrange
65-
var cronCalculator = new CronTimeCalculator("0 4 8-14 * *");
66-
var calculator = (ITimeCalculator)cronCalculator;
62+
var calculator = new CronTimeCalculator("0 4 8-14 * *");
6763

6864
var date = new DateTime(2018, 12, 22);
6965
var expected = new DateTime(2019, 01, 08, 4, 0, 0);
@@ -79,8 +75,7 @@ public void At0400OnEveryDayOfMonthFrom8Through14()
7975
public void At1415OnJanuaryFirst()
8076
{
8177
// Arrange
82-
var cronCalculator = new CronTimeCalculator("15 14 1 * *");
83-
var calculator = (ITimeCalculator)cronCalculator;
78+
var calculator = new CronTimeCalculator("15 14 1 * *");
8479

8580
var date = new DateTime(2018, 12, 22);
8681
var expected = new DateTime(2019, 1, 1, 14, 15, 0);
@@ -96,8 +91,7 @@ public void At1415OnJanuaryFirst()
9691
public void At2200OnEveryDayOfWeekFromMondayThroughFriday()
9792
{
9893
// Arrange
99-
var cronCalculator = new CronTimeCalculator("0 22 * * 1-5");
100-
var calculator = (ITimeCalculator)cronCalculator;
94+
var calculator = new CronTimeCalculator("0 22 * * 1-5");
10195

10296
var date = new DateTime(2018, 12, 22);
10397
var expected = new DateTime(2018, 12, 24, 22, 0, 0);
@@ -113,8 +107,7 @@ public void At2200OnEveryDayOfWeekFromMondayThroughFriday()
113107
public void EveryDayAt0500And1700Hours()
114108
{
115109
// Arrange
116-
var cronCalculator = new CronTimeCalculator("0 5,17 * * *");
117-
var calculator = (ITimeCalculator)cronCalculator;
110+
var calculator = new CronTimeCalculator("0 5,17 * * *");
118111

119112
var date = new DateTime(2018, 12, 22);
120113
var expected = new DateTime(2018, 12, 22, 5, 0, 0);
@@ -130,8 +123,7 @@ public void EveryDayAt0500And1700Hours()
130123
public void AtEveryMinute()
131124
{
132125
// Arrange
133-
var cronCalculator = new CronTimeCalculator("* * * * *");
134-
var calculator = (ITimeCalculator)cronCalculator;
126+
var calculator = new CronTimeCalculator("* * * * *");
135127

136128
var date = new DateTime(2018, 12, 22);
137129
var expected = new DateTime(2018, 12, 22, 0, 1, 0);
@@ -147,8 +139,7 @@ public void AtEveryMinute()
147139
public void AtEvery10Minutes()
148140
{
149141
// Arrange
150-
var cronCalculator = new CronTimeCalculator("*/10 * * * *");
151-
var calculator = (ITimeCalculator)cronCalculator;
142+
var calculator = new CronTimeCalculator("*/10 * * * *");
152143

153144
var date = new DateTime(2018, 12, 22);
154145
var expected = new DateTime(2018, 12, 22, 0, 10, 0);
@@ -164,8 +155,7 @@ public void AtEvery10Minutes()
164155
public void At1700OnSundayAndFriday()
165156
{
166157
// Arrange
167-
var cronCalculator = new CronTimeCalculator("0 17 * * sun,fri");
168-
var calculator = (ITimeCalculator)cronCalculator;
158+
var calculator = new CronTimeCalculator("0 17 * * sun,fri");
169159

170160
var date = new DateTime(2018, 12, 22);
171161
var expected = new DateTime(2018, 12, 23, 17, 0, 0);
@@ -181,8 +171,7 @@ public void At1700OnSundayAndFriday()
181171
public void EverySecond()
182172
{
183173
// Arrange
184-
var cronCalculator = new CronTimeCalculator("* * * * * *");
185-
var calculator = (ITimeCalculator)cronCalculator;
174+
var calculator = new CronTimeCalculator("* * * * * *");
186175

187176
var date = new DateTime(2018, 12, 23, 17, 0 , 0);
188177
var expected = new DateTime(2018, 12, 23, 17, 0, 1);

‎FluentScheduler.UnitTests/Fluent/1.Run/RunSpecifierTests.cs‎

Lines changed: 40 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ public void NowAndEvery()
1212
// Arrange
1313
var now = DateTime.Now;
1414

15-
var fluentCalculator = new FluentTimeCalculator();
16-
var calculator = (ITimeCalculator)fluentCalculator;
17-
var run = new RunSpecifier(fluentCalculator);
15+
var calculator = new FluentTimeCalculator();
16+
var run = new RunSpecifier(calculator);
1817

1918
// Act
2019
run.Now().AndEvery(10).Seconds();
@@ -37,9 +36,8 @@ public void EveryTimeSpan()
3736
var now = DateTime.Now;
3837
var time = new TimeSpan(1, 3, 0);
3938

40-
var fluentCalculator = new FluentTimeCalculator();
41-
var calculator = (ITimeCalculator)fluentCalculator;
42-
var run = new RunSpecifier(fluentCalculator);
39+
var calculator = new FluentTimeCalculator();
40+
var run = new RunSpecifier(calculator);
4341

4442
// Act
4543
run.Every(time);
@@ -56,9 +54,8 @@ public void ExecuteOnlyOnceEverySunday()
5654
var date = new DateTime(2020, 9, 1);
5755
var expected = new DateTime(2020, 9, 6);
5856

59-
var fluentCalculator = new FluentTimeCalculator();
60-
var calculator = (ITimeCalculator)fluentCalculator;
61-
var run = new RunSpecifier(fluentCalculator);
57+
var calculator = new FluentTimeCalculator();
58+
var run = new RunSpecifier(calculator);
6259

6360
// Act
6461
run.Every(DayOfWeek.Sunday);
@@ -84,9 +81,8 @@ public void ExecuteOnlyOnceEveryMonday()
8481
var date = new DateTime(2020, 9, 1);
8582
var expected = new DateTime(2020, 9, 7);
8683

87-
var fluentCalculator = new FluentTimeCalculator();
88-
var calculator = (ITimeCalculator)fluentCalculator;
89-
var run = new RunSpecifier(fluentCalculator);
84+
var calculator = new FluentTimeCalculator();
85+
var run = new RunSpecifier(calculator);
9086

9187
// Act
9288
run.Every(DayOfWeek.Monday);
@@ -112,9 +108,8 @@ public void ExecuteOnlyOnceEveryTuesday()
112108
var date = new DateTime(2020, 9, 1);
113109
var expected = new DateTime(2020, 9, 8);
114110

115-
var fluentCalculator = new FluentTimeCalculator();
116-
var calculator = (ITimeCalculator)fluentCalculator;
117-
var run = new RunSpecifier(fluentCalculator);
111+
var calculator = new FluentTimeCalculator();
112+
var run = new RunSpecifier(calculator);
118113

119114
// Act
120115
run.Every(DayOfWeek.Tuesday);
@@ -140,9 +135,8 @@ public void ExecuteOnlyOnceEveryThursday()
140135
var date = new DateTime(2020, 9, 1);
141136
var expected = new DateTime(2020, 9, 3);
142137

143-
var fluentCalculator = new FluentTimeCalculator();
144-
var calculator = (ITimeCalculator)fluentCalculator;
145-
var run = new RunSpecifier(fluentCalculator);
138+
var calculator = new FluentTimeCalculator();
139+
var run = new RunSpecifier(calculator);
146140

147141
// Act
148142
run.Every(DayOfWeek.Thursday);
@@ -168,9 +162,8 @@ public void ExecuteOnlyOnceEveryFriday()
168162
var date = new DateTime(2020, 9, 1);
169163
var expected = new DateTime(2020, 9, 4);
170164

171-
var fluentCalculator = new FluentTimeCalculator();
172-
var calculator = (ITimeCalculator)fluentCalculator;
173-
var run = new RunSpecifier(fluentCalculator);
165+
var calculator = new FluentTimeCalculator();
166+
var run = new RunSpecifier(calculator);
174167

175168
// Act
176169
run.Every(DayOfWeek.Friday);
@@ -196,9 +189,8 @@ public void EverySaturday()
196189
var date = new DateTime(2020, 9, 1);
197190
var expected = new DateTime(2020, 9, 5);
198191

199-
var fluentCalculator = new FluentTimeCalculator();
200-
var calculator = (ITimeCalculator)fluentCalculator;
201-
var run = new RunSpecifier(fluentCalculator);
192+
var calculator = new FluentTimeCalculator();
193+
var run = new RunSpecifier(calculator);
202194

203195
// Act
204196
run.Every(DayOfWeek.Saturday);
@@ -224,9 +216,8 @@ public void OnceAtAndEvery()
224216
var now = DateTime.Now;
225217
var at = new DateTime(2000, 10, 10, 10, 10, 10);
226218

227-
var fluentCalculator = new FluentTimeCalculator();
228-
var calculator = (ITimeCalculator)fluentCalculator;
229-
var run = new RunSpecifier(fluentCalculator);
219+
var calculator = new FluentTimeCalculator();
220+
var run = new RunSpecifier(calculator);
230221

231222
// Act
232223
run.OnceAt(at).AndEvery(10).Seconds();
@@ -248,9 +239,8 @@ public void Now()
248239
// Arrange
249240
var now = DateTime.Now;
250241

251-
var fluentCalculator = new FluentTimeCalculator();
252-
var calculator = (ITimeCalculator)fluentCalculator;
253-
var run = new RunSpecifier(fluentCalculator);
242+
var calculator = new FluentTimeCalculator();
243+
var run = new RunSpecifier(calculator);
254244

255245
// Act
256246
run.Now();
@@ -274,9 +264,8 @@ public void OnceAtHoursMinutes()
274264
var hours = 13;
275265
var minutes = 50;
276266

277-
var fluentCalculator = new FluentTimeCalculator();
278-
var calculator = (ITimeCalculator)fluentCalculator;
279-
var run = new RunSpecifier(fluentCalculator);
267+
var calculator = new FluentTimeCalculator();
268+
var run = new RunSpecifier(calculator);
280269

281270
// Act
282271
run.OnceAt(hours, minutes);
@@ -299,9 +288,8 @@ public void OnceAtTimeSpan()
299288
var now = DateTime.Today;
300289
var at = new TimeSpan(13, 50, 0);
301290

302-
var fluentCalculator = new FluentTimeCalculator();
303-
var calculator = (ITimeCalculator)fluentCalculator;
304-
var run = new RunSpecifier(fluentCalculator);
291+
var calculator = new FluentTimeCalculator();
292+
var run = new RunSpecifier(calculator);
305293

306294
// Act
307295
run.OnceAt(at);
@@ -324,9 +312,8 @@ public void OnceAtDateTime()
324312
var now = DateTime.Now;
325313
var at = new DateTime(2000, 10, 10, 10, 10, 10);
326314

327-
var fluentCalculator = new FluentTimeCalculator();
328-
var calculator = (ITimeCalculator)fluentCalculator;
329-
var run = new RunSpecifier(fluentCalculator);
315+
var calculator = new FluentTimeCalculator();
316+
var run = new RunSpecifier(calculator);
330317

331318
// Act
332319
run.OnceAt(at);
@@ -348,9 +335,8 @@ public void OnceIn()
348335
// Arrange
349336
var now = DateTime.Today;
350337

351-
var fluentCalculator = new FluentTimeCalculator();
352-
var calculator = (ITimeCalculator)fluentCalculator;
353-
var run = new RunSpecifier(fluentCalculator);
338+
var calculator = new FluentTimeCalculator();
339+
var run = new RunSpecifier(calculator);
354340

355341
// Act
356342
run.OnceIn(10).Seconds();
@@ -373,9 +359,8 @@ public void OnceInTimeSpan()
373359
var now = DateTime.Today;
374360
var time = TimeSpan.FromSeconds(10);
375361

376-
var fluentCalculator = new FluentTimeCalculator();
377-
var calculator = (ITimeCalculator)fluentCalculator;
378-
var run = new RunSpecifier(fluentCalculator);
362+
var calculator = new FluentTimeCalculator();
363+
var run = new RunSpecifier(calculator);
379364

380365
// Act
381366
run.OnceIn(time);
@@ -398,9 +383,8 @@ public void EveryWeekday()
398383
var now = new DateTime(2020, 9, 2);
399384
var expected = new DateTime(2020, 9, 3);
400385

401-
var fluentCalculator = new FluentTimeCalculator();
402-
var calculator = (ITimeCalculator)fluentCalculator;
403-
var run = new RunSpecifier(fluentCalculator);
386+
var calculator = new FluentTimeCalculator();
387+
var run = new RunSpecifier(calculator);
404388

405389
// Act
406390
run.EveryWeekday();
@@ -425,9 +409,8 @@ public void EveryWeekend()
425409
var now = new DateTime(2025, 8, 9);
426410
var expected = new DateTime(2025, 8, 10);
427411

428-
var fluentCalculator = new FluentTimeCalculator();
429-
var calculator = (ITimeCalculator)fluentCalculator;
430-
var run = new RunSpecifier(fluentCalculator);
412+
var calculator = new FluentTimeCalculator();
413+
var run = new RunSpecifier(calculator);
431414

432415
// Act
433416
run.EveryWeekend();
@@ -454,9 +437,8 @@ public void Everyday()
454437
var now = new DateTime(2025, 8, 20, 10, 0, 0);
455438
var expected = new DateTime(2025, 8, 20, 10, 0, 0);
456439

457-
var fluentCalculator = new FluentTimeCalculator();
458-
var calculator = (ITimeCalculator)fluentCalculator;
459-
var run = new RunSpecifier(fluentCalculator);
440+
var calculator = new FluentTimeCalculator();
441+
var run = new RunSpecifier(calculator);
460442

461443
calculator.Now = () => now;
462444

@@ -496,9 +478,8 @@ public void EveryMonth()
496478
var now = new DateTime(2025, 8, 2, 10, 0, 0);
497479
var expected = new DateTime(2025, 9, 2, 15, 0, 0);
498480

499-
var fluentCalculator = new FluentTimeCalculator();
500-
var calculator = (ITimeCalculator)fluentCalculator;
501-
var run = new RunSpecifier(fluentCalculator);
481+
var calculator = new FluentTimeCalculator();
482+
var run = new RunSpecifier(calculator);
502483

503484
// Act
504485
run.Every(1).Months().On(2).At(15, 0);
@@ -525,9 +506,8 @@ public void EveryWeek()
525506
var now = new DateTime(2025, 8, 11, 10, 0, 0);
526507
var expected = new DateTime(2025, 8, 18, 15, 0, 0);
527508

528-
var fluentCalculator = new FluentTimeCalculator();
529-
var calculator = (ITimeCalculator)fluentCalculator;
530-
var run = new RunSpecifier(fluentCalculator);
509+
var calculator = new FluentTimeCalculator();
510+
var run = new RunSpecifier(calculator);
531511

532512
// Act
533513
run.Every(1).Weeks().Between(15, 0, 16, 0);

0 commit comments

Comments
 (0)