Skip to content

Commit 00b4454

Browse files
authored
[CQ] suppress insecure URL warnings for devtools URLs (#8081)
We can't make URLs secure, so the warnings are just noise. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
1 parent 1ad4afa commit 00b4454

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

Diff for: flutter-idea/src/io/flutter/devtools/DevToolsUrl.java

+1
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ private DevToolsUrl(Builder builder) {
159159
}
160160
}
161161

162+
@SuppressWarnings("HttpUrlsUsage")
162163
@NotNull
163164
public String getUrlString() {
164165
final List<String> params = new ArrayList<>();

Diff for: flutter-idea/src/io/flutter/run/SdkFields.java

+1
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,7 @@ public GeneralCommandLine createFlutterSdkRunCommand(
227227
}
228228
}, "Starting DevTools", false, project);
229229
final DevToolsInstance instance = devToolsFuture.get();
230+
//noinspection HttpUrlsUsage
230231
args = ArrayUtil.append(args, "--devtools-server-address=http://" + instance.host() + ":" + instance.port());
231232
}
232233
catch (Exception e) {

Diff for: flutter-idea/src/io/flutter/run/bazel/BazelFields.java

+1
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ else if (FlutterSettings.getInstance().isEnableBazelHotRestart() && !hasEnabledA
333333
}
334334
}, "Starting DevTools", false, project);
335335
final DevToolsInstance instance = devToolsFuture.get();
336+
//noinspection HttpUrlsUsage
336337
commandLine.addParameter("--devtools-server-address=http://" + instance.host() + ":" + instance.port());
337338
}
338339
catch (Exception e) {

Diff for: flutter-idea/testSrc/unit/io/flutter/utils/UrlUtilsTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import static org.junit.Assert.assertEquals;
66

7+
@SuppressWarnings("HttpUrlsUsage")
78
public class UrlUtilsTest {
89
@Test
910
public void testGenerateHtmlFragmentWithHrefTags() {

0 commit comments

Comments
 (0)