Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style added in searchbar #11683

Merged
merged 1 commit into from
Feb 6, 2025
Merged

style added in searchbar #11683

merged 1 commit into from
Feb 6, 2025

Conversation

zalabhavy
Copy link
Contributor

@zalabhavy zalabhavy commented Feb 6, 2025

Added a round style to the search bar and adjusted the margin, padding of the search icon, and placeholder to improve the appearance of the rounded search bar.

image

Fixed #11678

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@zalabhavy zalabhavy requested review from sfshaza2, antfitch, parlough and a team as code owners February 6, 2025 08:25
@parlough
Copy link
Member

parlough commented Feb 6, 2025

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit c4f55fc):

https://flutter-docs-prod--pr11683-search-551stoap.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more consistent! Thanks again :D

@parlough parlough merged commit 87d9606 into flutter:main Feb 6, 2025
9 checks passed
@zalabhavy
Copy link
Contributor Author

@parlough I want to contribute to (https://github.com/flutter/flutter), but I don't know how to set it up and run it on my local system. Can you please help me with that?

@parlough
Copy link
Member

parlough commented Feb 7, 2025

@zalabhavy said:

@parlough I want to contribute to (https://github.com/flutter/flutter), but I don't know how to set it up and run it on my local system. Can you please help me with that?

It depends on what part you want to contribute to. If you want to contribute to just the framework, you can follow the Setting up the framework development environment instructions.

If you also want to make changes to the engine too, you'll need to follow the Setting up the engine development environment instructions first.

There's also a #hackers-new channel on the Flutter contributor's Discord where you can ask questions about contributing to flutter/flutter or setting up your environment. https://flutter.dev/chat has the link to join there and other information. I check there as well, so if you have any specific issues running it on your system, feel free to ping me there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give Round Radius to SearchBar
3 participants